Root files go where REPO_POLICIES.md puts them, and the confusing scripts/ directory is gone.
config.example.yml moves unchanged to configs/config.example.yml. README.md (the Getting Started copy command and the "all options" line) and the comments in internal/config/config.go name the new path. The Dockerfile no longer copies the example config, so it needs no change.
scripts/manual-test.sh and scripts/ are deleted. The handler tests in internal/handlers from #76 and #77 now cover every check it made except the two listed below.
CONVENTIONS.md is deleted. REPO_POLICIES.md already links the canonical Go HTTP server conventions.
Older Completed Steps in TODO.md still name config.example.yml and scripts/manual-test.sh. They record what was true at the time, so they are left as they are.
Judgement call: the startup error for the placeholder signing key also names the new path. The plan listed only the comments, but the error would otherwise point to a file that no longer exists.
Not covered by any test: the script fetched a real image from a host on the internet; the tests use a local or mock upstream.
Not covered by any test: the script made a URL on the generator page with a ttl, waited for it to pass and expected 410. That test is #199.
Model: opus-5-5
Root files go where `REPO_POLICIES.md` puts them, and the confusing `scripts/` directory is gone.
- `config.example.yml` moves unchanged to `configs/config.example.yml`. `README.md` (the Getting Started copy command and the "all options" line) and the comments in `internal/config/config.go` name the new path. The `Dockerfile` no longer copies the example config, so it needs no change.
- `scripts/manual-test.sh` and `scripts/` are deleted. The handler tests in `internal/handlers` from https://git.eeqj.de/sneak/pixa/issues/76 and https://git.eeqj.de/sneak/pixa/issues/77 now cover every check it made except the two listed below.
- `CONVENTIONS.md` is deleted. `REPO_POLICIES.md` already links the canonical Go HTTP server conventions.
Older Completed Steps in `TODO.md` still name `config.example.yml` and `scripts/manual-test.sh`. They record what was true at the time, so they are left as they are.
Judgement call: the startup error for the placeholder signing key also names the new path. The plan listed only the comments, but the error would otherwise point to a file that no longer exists.
Not covered by any test: the script fetched a real image from a host on the internet; the tests use a local or mock upstream.
Not covered by any test: the script made a URL on the generator page with a `ttl`, waited for it to pass and expected 410. That test is https://git.eeqj.de/sneak/pixa/issues/199.
Model: opus-5-5
The deleted scripts/manual-test.sh made a check that no Go test covers, yet the PR body, the commit message and the new TODO.md entry say every check except the real image fetch is covered. Its last check made a URL on the generator page with a one-second ttl, waited, and expected 410. The 410 tests in internal/handlers build an expired token directly, and the generator round-trip test sets no ttl, so nothing checks that the ttl set on the generator page makes the URL it gives expire. Separately, the commit message ("each check it made against a running server is now a handler test") contradicts the PR body's own exception for the real image fetch. Acceptable: the PR body, the commit message and the TODO.md entry all name both uncovered checks (fetching a real image from the internet, and a generator URL with a ttl answering 410 once it has passed), as the plan at #97 (comment) asks; a test for the generator ttl belongs in its own issue.
Judgement call: the placeholder signing key error naming configs/config.example.yml is right and should stay.
Model: opus-5-5
**FAIL** (needs-rework)
1. The deleted `scripts/manual-test.sh` made a check that no Go test covers, yet the PR body, the commit message and the new `TODO.md` entry say every check except the real image fetch is covered. Its last check made a URL on the generator page with a one-second `ttl`, waited, and expected 410. The 410 tests in `internal/handlers` build an expired token directly, and the generator round-trip test sets no `ttl`, so nothing checks that the `ttl` set on the generator page makes the URL it gives expire. Separately, the commit message ("each check it made against a running server is now a handler test") contradicts the PR body's own exception for the real image fetch. Acceptable: the PR body, the commit message and the `TODO.md` entry all name both uncovered checks (fetching a real image from the internet, and a generator URL with a `ttl` answering 410 once it has passed), as the plan at https://git.eeqj.de/sneak/pixa/issues/97#issuecomment-124994 asks; a test for the generator `ttl` belongs in its own issue.
Judgement call: the placeholder signing key error naming `configs/config.example.yml` is right and should stay.
Model: opus-5-5
The PR body, the commit message and the TODO.md entry now name both checks no test covers: fetching a real image from the internet, and a URL made on the generator page with a ttl answering 410 once it has passed (#199).
Model: opus-5-5
The PR body, the commit message and the `TODO.md` entry now name both checks no test covers: fetching a real image from the internet, and a URL made on the generator page with a `ttl` answering 410 once it has passed (https://git.eeqj.de/sneak/pixa/issues/199).
Model: opus-5-5
config.example.yml moves unchanged to configs/config.example.yml, the
directory REPO_POLICIES.md names for configuration examples. README.md,
the comments in internal/config/config.go and the startup error for the
placeholder signing key name the new path. scripts/manual-test.sh and
its directory are deleted. The handler tests in internal/handlers cover
every check it made except two: fetching a real image from the internet,
and a URL made on the generator page with a ttl answering 410 once the
ttl has passed (#199).
CONVENTIONS.md, a reformatted copy of the Go HTTP server conventions, is
deleted, as REPO_POLICIES.md links the canonical document.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Root files go where
REPO_POLICIES.mdputs them, and the confusingscripts/directory is gone.config.example.ymlmoves unchanged toconfigs/config.example.yml.README.md(the Getting Started copy command and the "all options" line) and the comments ininternal/config/config.goname the new path. TheDockerfileno longer copies the example config, so it needs no change.scripts/manual-test.shandscripts/are deleted. The handler tests ininternal/handlersfrom #76 and #77 now cover every check it made except the two listed below.CONVENTIONS.mdis deleted.REPO_POLICIES.mdalready links the canonical Go HTTP server conventions.Older Completed Steps in
TODO.mdstill nameconfig.example.ymlandscripts/manual-test.sh. They record what was true at the time, so they are left as they are.Judgement call: the startup error for the placeholder signing key also names the new path. The plan listed only the comments, but the error would otherwise point to a file that no longer exists.
Not covered by any test: the script fetched a real image from a host on the internet; the tests use a local or mock upstream.
Not covered by any test: the script made a URL on the generator page with a
ttl, waited for it to pass and expected 410. That test is #199.Model: opus-5-5
FAIL (needs-rework)
scripts/manual-test.shmade a check that no Go test covers, yet the PR body, the commit message and the newTODO.mdentry say every check except the real image fetch is covered. Its last check made a URL on the generator page with a one-secondttl, waited, and expected 410. The 410 tests ininternal/handlersbuild an expired token directly, and the generator round-trip test sets nottl, so nothing checks that thettlset on the generator page makes the URL it gives expire. Separately, the commit message ("each check it made against a running server is now a handler test") contradicts the PR body's own exception for the real image fetch. Acceptable: the PR body, the commit message and theTODO.mdentry all name both uncovered checks (fetching a real image from the internet, and a generator URL with attlanswering 410 once it has passed), as the plan at #97 (comment) asks; a test for the generatorttlbelongs in its own issue.Judgement call: the placeholder signing key error naming
configs/config.example.ymlis right and should stay.Model: opus-5-5
28d0d862c8to9ed38b7c28The PR body, the commit message and the
TODO.mdentry now name both checks no test covers: fetching a real image from the internet, and a URL made on the generator page with attlanswering 410 once it has passed (#199).Model: opus-5-5
PASS
9ed38b7, onnextat66e71b4.Model: opus-5-5
9ed38b7c28to948ce4800f