sneak/pixa
1
0
Fork 0
Code Issues 18 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

No test that a URL made on the generator page with a ttl expires (410) #199

New Issue
Open
opened 2026-10-04 20:24:55 +02:00 by clawbot · 1 comment
clawbot commented 2026-10-04 20:24:55 +02:00
Collaborator
Copy Link
Copy Source

Found by the review of #194 (#194 (comment)). The deleted scripts/manual-test.sh made a URL on the generator page with a one-second ttl, waited, and expected 410. No Go test covers that: the 410 tests in internal/handlers build an expired token directly, and the generator round-trip test sets no ttl.

Plan: one new test in internal/handlers, next to the generator round trip: POST /generate with a logged-in session and a short ttl makes a URL that /v1/e/ serves before the ttl passes and answers 410 after it. Use the clock seam the token code already has if there is one, so the test does not sleep for the ttl; if there is none, a ttl of one second and a wait just past it is acceptable. New test only.

Model: opus-5-5

Found by the review of https://git.eeqj.de/sneak/pixa/pulls/194 (https://git.eeqj.de/sneak/pixa/pulls/194#issuecomment-125099). The deleted `scripts/manual-test.sh` made a URL on the generator page with a one-second `ttl`, waited, and expected 410. No Go test covers that: the 410 tests in `internal/handlers` build an expired token directly, and the generator round-trip test sets no `ttl`. Plan: one new test in `internal/handlers`, next to the generator round trip: `POST /generate` with a logged-in session and a short `ttl` makes a URL that `/v1/e/` serves before the `ttl` passes and answers 410 after it. Use the clock seam the token code already has if there is one, so the test does not sleep for the `ttl`; if there is none, a `ttl` of one second and a wait just past it is acceptable. New test only. Model: opus-5-5
clawbot commented 2026-10-04 21:19:53 +02:00
Author
Collaborator
Copy Link
Copy Source

New test in #201: a URL made on the generator page with a ttl of one second is served by /v1/e/ at once and answers 410 two seconds later. There is no way for a test to set the clock, so it waits for real.

Model: opus-5-5

New test in https://git.eeqj.de/sneak/pixa/pulls/201: a URL made on the generator page with a `ttl` of one second is served by `/v1/e/` at once and answers 410 two seconds later. There is no way for a test to set the clock, so it waits for real. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#199