Repo layout: non-canonical root files, a confusing scripts/ directory, and a stale reformatted CONVENTIONS.md #97
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
From the audit against the canonical
REPO_POLICIES.md, verified againstmainat61f42e6.1. Files in the root that policy places in subdirectories. The policy states:
> Avoid putting files in the repo root unless necessary. Root should contain only project-level config files (
README.md,Makefile,Dockerfile,LICENSE,.gitignore,.editorconfig,REPO_POLICIES.md, and language-specific config). Everything else goes in a subdirectory.with a canonical subdirectory list including
configs/for "configuration templates and examples" anddocs/for "documentation and markdown (README.md stays in root)".In the root today:
CONVENTIONS.md(31 KB, belongs indocs/) andconfig.example.yml(belongs inconfigs/).2. A
scripts/directory alongside the canonicalscript/.scripts/manual-test.shsits in a directory that is neither the Scripts to Rule Them All entrypoint dir (script/) nor the canonicalbin/. Having bothscript/andscripts/is actively confusing — they differ by one character and mean different things.3.
CONVENTIONS.mdis a stale, reformatted copy of a canonical document. The policy requires:> Cross-project documentation (such as this file) must include
last_modified: YYYY-MM-DDin the YAML front matter so it can be kept in sync with the authoritative source as policies evolve.diffagainst the canonicalGO_HTTP_SERVER_CONVENTIONS.mdproduces 367 lines of difference. pixa's copy has no YAML front matter at all (canonical hastitle:andlast_modified: 2026-02-22), is reflowed to unwrapped long lines, and uses different list markers and demoted heading levels. Because it was reformatted, there is no way to tell which differences are genuinely stale content and which are cosmetic — which is precisely the problem thelast_modifiedrequirement exists to prevent.The contrast is instructive: the repo's
REPO_POLICIES.mdis byte-identical to canonical (sha256117dde7f148ed3cd693b333312f6345a0a0ee84fadbbe5cca559ca6fed4a1775). That is the standard to meet.Not flagged:
TODO.mdin the root. It is README-referenced and established convention across sneak's repos.Definition of done
config.example.yml→configs/; updateDockerfile:71(COPY config.example.yml /etc/pixa/config.yml) and theREADME.md:119reference.scripts/manual-test.sh→bin/; remove thescripts/directory; update any references.CONVENTIONS.mdreplaced with a byte-identical copy of the canonicalGO_HTTP_SERVER_CONVENTIONS.md(front matter andlast_modifiedintact) and moved todocs/— or deleted outright if the reference to it inREPO_POLICIES.mdis considered sufficient. Recommend deleting: a vendored copy is a second thing to keep in sync, and the canonical source is already referenced.docker build .green (theCOPYpath change is the one thing that can break the image) andmake checkgreen.Coordination
Touches
README.mdandDockerfile, both of which the open PRs modify. Do after both #55 and #54 merge.