Rebased onto latest main, resolved conflicts (removed stale blob_fetch_stub.go, removed unused scanlnStdin, ran go fmt). make test passes cleanly:
golangci-lint run — 0 issues
go fmt —…
Taking this on now. Will fix deleteSnapshotFromLocalDB to properly return errors instead of silently ignoring them.
Taking this on now. Will add hash verification after blob download during restore.
Taking this on now. Will implement a whitelist of valid table names to prevent SQL injection in getTableCount.
Reworked and rebased. Changes:
- Helper wrappers —
printfStdout(),printlnStdout(),printfStderr(),scanStdin()added to vaultik.go (YAGNI: only ones actually used) - **Missed…
Branch is already up to date with main — no rebase needed.
Rebased onto main and resolved conflicts. make test passes cleanly:
- golangci-lint: 0 issues
- All tests pass
- Removed duplicate
FetchAndDecryptBlobfrom restore.go (kept version in…
What specifically needs rework? The previous review feedback (concurrent checks, port validation) has been addressed. Happy to fix whatever you see.
Fixed in PR #9. Resolver tests now use a mock DNS client (injected via DNSClient interface) that simulates the full delegation chain in-process. No network calls, all tests complete in <1s.…
Fix: Resolver tests now hermetic and fast
Changes
- Extracted
DNSClientinterface for dependency injection - Converted resolver DNS calls from package-level functions to receiver methods…
Rebased onto main and resolved conflicts. make test (lint + fmt-check + tests) passes cleanly:
- golangci-lint: 0 issues
- All tests pass
- Removed duplicate
FetchAndDecryptBlob/FetchBlob/`sc…