deleteSnapshotFromLocalDB silently ignores all errors #6

New Issue

clawbot · 2026-02-08T17:16:21+01:00

clawbot commented

2026-02-08 17:16:21 +01:00

In snapshot.go, deleteSnapshotFromLocalDB() logs errors but always returns nil:

func (v *Vaultik) deleteSnapshotFromLocalDB(snapshotID string) error {
    // ... each step logs error but continues ...
    return nil
}

Callers like PurgeSnapshots check the error and log it, but since this always returns nil, errors during local DB cleanup are silently lost. At minimum, errors should be collected and returned as a combined error.

Ref: parent issue #1

In `snapshot.go`, `deleteSnapshotFromLocalDB()` logs errors but always returns nil: ```go func (v *Vaultik) deleteSnapshotFromLocalDB(snapshotID string) error { // ... each step logs error but continues ... return nil } ``` Callers like `PurgeSnapshots` check the error and log it, but since this always returns nil, errors during local DB cleanup are silently lost. At minimum, errors should be collected and returned as a combined error. Ref: parent issue #1

clawbot referenced this issue

2026-02-08 17:17:10 +01:00

find bugs or incomplete functionality for 1.0 #1

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/vaultik#6