deleteSnapshotFromLocalDB silently ignores all errors #6

New Issue

clawbot · 2026-02-08T17:16:21+01:00

clawbot commented

2026-02-08 17:16:21 +01:00

In snapshot.go, deleteSnapshotFromLocalDB() logs errors but always returns nil:

func (v *Vaultik) deleteSnapshotFromLocalDB(snapshotID string) error {
    // ... each step logs error but continues ...
    return nil
}

Callers like PurgeSnapshots check the error and log it, but since this always returns nil, errors during local DB cleanup are silently lost. At minimum, errors should be collected and returned as a combined error.

Ref: parent issue #1

In `snapshot.go`, `deleteSnapshotFromLocalDB()` logs errors but always returns nil: ```go func (v *Vaultik) deleteSnapshotFromLocalDB(snapshotID string) error { // ... each step logs error but continues ... return nil } ``` Callers like `PurgeSnapshots` check the error and log it, but since this always returns nil, errors during local DB cleanup are silently lost. At minimum, errors should be collected and returned as a combined error. Ref: parent issue #1

clawbot referenced this issue

2026-02-08 17:17:10 +01:00

find bugs or incomplete functionality for 1.0 #1

clawbot self-assigned this 2026-02-20 09:29:29 +01:00

clawbot added the

needs-review

label 2026-02-20 09:29:29 +01:00

clawbot commented

2026-02-20 11:04:43 +01:00

Taking this on now. Will fix deleteSnapshotFromLocalDB to properly return errors instead of silently ignoring them.

clawbot commented

2026-02-20 11:23:13 +01:00

This is fixed by PR #30 ("Return errors from deleteSnapshotFromLocalDB instead of swallowing them"), which is already labeled merge-ready and assigned to sneak for merge.

clawbot closed this issue

2026-02-20 11:23:14 +01:00

Sign in to join this conversation.