In snapshot.go, deleteSnapshotFromLocalDB() logs errors but always returns nil:
func(v*Vaultik)deleteSnapshotFromLocalDB(snapshotIDstring)error{// ... each step logs error but continues ...returnnil}
Callers like PurgeSnapshots check the error and log it, but since this always returns nil, errors during local DB cleanup are silently lost. At minimum, errors should be collected and returned as a combined error.
In `snapshot.go`, `deleteSnapshotFromLocalDB()` logs errors but always returns nil:
```go
func (v *Vaultik) deleteSnapshotFromLocalDB(snapshotID string) error {
// ... each step logs error but continues ...
return nil
}
```
Callers like `PurgeSnapshots` check the error and log it, but since this always returns nil, errors during local DB cleanup are silently lost. At minimum, errors should be collected and returned as a combined error.
Ref: parent issue #1
This is fixed by PR #30 ("Return errors from deleteSnapshotFromLocalDB instead of swallowing them"), which is already labeled merge-ready and assigned to sneak for merge.
This is fixed by PR #30 ("Return errors from deleteSnapshotFromLocalDB instead of swallowing them"), which is already labeled merge-ready and assigned to sneak for merge.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In
snapshot.go,deleteSnapshotFromLocalDB()logs errors but always returns nil:Callers like
PurgeSnapshotscheck the error and log it, but since this always returns nil, errors during local DB cleanup are silently lost. At minimum, errors should be collected and returned as a combined error.Ref: parent issue #1
Taking this on now. Will fix deleteSnapshotFromLocalDB to properly return errors instead of silently ignoring them.
This is fixed by PR #30 ("Return errors from deleteSnapshotFromLocalDB instead of swallowing them"), which is already labeled merge-ready and assigned to sneak for merge.