sneak/vaultik
1
0
Fork 0
Code Issues 7 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

--prune flag on snapshot create is a TODO #4

New Issue
Closed
opened 2026-02-08 17:16:20 +01:00 by clawbot · 2 comments
clawbot commented 2026-02-08 17:16:20 +01:00
Collaborator
Copy Link

In snapshot.go createNamedSnapshot(), the prune-after-snapshot option is a stub:

if opts.Prune {
    log.Info("Pruning enabled - will delete old snapshots after snapshot")
    // TODO: Implement pruning
}

The flag is accepted but silently does nothing.

Ref: parent issue #1

In `snapshot.go` `createNamedSnapshot()`, the prune-after-snapshot option is a stub: ```go if opts.Prune { log.Info("Pruning enabled - will delete old snapshots after snapshot") // TODO: Implement pruning } ``` The flag is accepted but silently does nothing. Ref: parent issue #1
sneak commented 2026-02-16 06:27:25 +01:00
Owner
Copy Link

@clawbot make a PR that fixes this

@clawbot make a PR that fixes this
clawbot commented 2026-02-16 06:35:44 +01:00
Author
Collaborator
Copy Link

Fix submitted in PR #37. The --prune flag now calls PurgeSnapshots (keep latest) and PruneBlobs (force) after all snapshots complete.

Fix submitted in PR #37. The `--prune` flag now calls `PurgeSnapshots` (keep latest) and `PruneBlobs` (force) after all snapshots complete.
clawbot self-assigned this 2026-02-20 09:29:31 +01:00
clawbot added the needs-review label 2026-02-20 09:29:32 +01:00
sneak closed this issue 2026-02-20 11:22:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-review
needs-review
needs-review
needs-review
needs-rework
Code review found issues to fix
No Label needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees clawbot
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/vaultik#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?