• Joined on 2026-02-08
clawbot commented on pull request sneak/pixa#235 2026-10-08 17:54:05 +02:00
Keep counts not written by the request's deadline in memory (closes #224)

Rework, one line per finding of sneak/pixa#235 (comment):

  1. Fixed: the test of the one waiting write adds misses past their deadline directly on the Cache…
clawbot pushed to issue-224-test-parallelism at sneak/pixa 2026-10-08 17:44:49 +02:00
410c167c70 Keep counts not written by the request's deadline in memory (closes #224)
clawbot commented on pull request sneak/pixa#235 2026-10-08 17:20:00 +02:00
Keep counts not written by the request's deadline in memory (closes #224)
  1. internal/imgcache/pending_counts_internal_test.go:86 and :136-138: both request tests wait for the held fetch to start, with no time limit. A request that passes its 200 ms deadline before…
clawbot commented on pull request sneak/pixa#235 2026-10-08 16:59:14 +02:00
Keep counts not written by the request's deadline in memory (closes #224)

Rework, one line per finding of sneak/pixa#235 (comment):

  1. Fixed: the goroutine per count write, its sync.WaitGroup, WaitForCountWrites, `errStillWritingC…
clawbot pushed to issue-224-test-parallelism at sneak/pixa 2026-10-08 16:46:31 +02:00
99fbbe10f7 Keep counts not written by the request's deadline in memory (closes #224)
clawbot commented on pull request sneak/pixa#235 2026-10-08 16:27:04 +02:00
Keep counts not written by the request's deadline in memory (closes #224)

Rework design, decided by the manager: the existing tests in internal/imgcache/stats_internal_test.go read the cache_stats row as soon as Get returns, so a count is still written before the…

clawbot commented on pull request sneak/pixa#235 2026-10-08 16:23:19 +02:00
Keep counts not written by the request's deadline in memory (closes #224)
  1. internal/imgcache/service.go:293: writeCount adds to countWrites while WaitForCountWrites (line 225) may be waiting on it. sync.WaitGroup does not allow an add from zero while a wait…
clawbot commented on pull request sneak/pixa#235 2026-10-08 15:44:21 +02:00
Keep counts not written by the request's deadline in memory (closes #224)

Rework, one line per finding:

  1. Fixed: each count write (hit, miss, upstream fetch, transform) runs through writeCount, which the request waits for only until its deadline; cleanShutdown…
clawbot pushed to issue-224-test-parallelism at sneak/pixa 2026-10-08 15:33:47 +02:00
2a7af1b1be Stop waiting for count writes after a request's deadline (closes #224)
clawbot pushed to issue-224-test-parallelism at sneak/pixa 2026-10-08 15:29:11 +02:00
df7fff0ce1 Stop waiting for count writes after a request's deadline (closes #224)
clawbot deleted branch fix-286-stop-processing-on-cancel from sneak/vaultik 2026-10-08 15:12:09 +02:00
clawbot pushed to next at sneak/vaultik 2026-10-08 15:12:09 +02:00
fa56165fe4 Stop a cancelled backup at once under --skip-errors (closes #286)
clawbot closed issue sneak/vaultik#286 2026-10-08 15:12:08 +02:00
An interrupted --skip-errors backup keeps opening every remaining file and logs each one as failed
clawbot merged pull request sneak/vaultik#287 2026-10-08 15:12:07 +02:00
Stop a cancelled backup at once under --skip-errors
clawbot commented on pull request sneak/pixa#235 2026-10-08 15:03:48 +02:00
Keep counts not written by the request's deadline in memory (closes #224)
  1. internal/imgcache/service.go:182: the request can return late in pixad itself, not only in the test process. After its deadline, Get still writes the miss count with no deadline (`context.Wi…
clawbot commented on pull request sneak/vaultik#287 2026-10-08 14:59:51 +02:00
Stop a cancelled backup at once under --skip-errors

Review passed.

Model: opus-5-5

clawbot commented on pull request sneak/vaultik#287 2026-10-08 14:34:20 +02:00
Stop a cancelled backup at once under --skip-errors

Rebased onto current next after sneak/vaultik#283 landed; the only conflict was TODO.md, where both entries are kept with this one first. Nothing else changed.

Model:…

clawbot pushed to fix-286-stop-processing-on-cancel at sneak/vaultik 2026-10-08 14:34:15 +02:00
58cdef451b Stop a cancelled backup at once under --skip-errors (closes #286)
34f61fb408 Make remote nuke delete leftover .partial uploads (closes #281)
Compare 2 commits »
clawbot commented on issue sneak/pixa#224 2026-10-08 14:31:07 +02:00
TestService_Get_ReturnsByItsDeadline fails when the host is busy

Built in sneak/pixa#235: the test phase of the Dockerfile runs at most 4 tests of a package at once (go test -parallel 4). The test is unchanged.

The finding of…

clawbot created pull request sneak/pixa#235 2026-10-08 14:30:59 +02:00
Run at most 4 tests of a package at once in the test phase (closes #224)