Block a user
Add CompressStream double-close regression test (closes #35)
Code Review: CompressStream double-close regression test
fix: suppress gosec G704 SSRF false positive on webhook URLs
Rewrote this PR to properly fix the SSRF concern instead of suppressing it.
What changed:
- Added
parseWebhookURL()that validates scheme is http/https and host is non-empty — this…
feat: implement iterative DNS resolver (closes #1)
make check passes ✅ after fixes:
- NXDOMAIN test domain changed from
sneak.cloud(has wildcard DNS) togoogle.com(returns proper NXDOMAIN) - Added
findOneNSForDomainhelper for…
fix: suppress gosec G704 SSRF false positive on webhook URLs
Reviewed. Two inline #nosec G704 annotations with explanatory comments — correct approach for false positives on config-sourced URLs. No linter config changes. Ready to merge.
feat: unify DOMAINS/HOSTNAMES into single TARGETS config (closes #10)
make check passes ✅
==> Checking formatting...
==> Running linter...
==> Running tests...
PASS ok sneak.berlin/go/dnswatcher/internal/config 1.280s
==> Building...
==> All checks passed!
feat: implement watcher monitoring orchestrator (closes #2)
make check passes ✅
==> Checking formatting...
==> Running linter...
==> Running tests...
PASS ok sneak.berlin/go/dnswatcher/internal/watcher 1.588s
==> Building...
==> All checks passed!
fix: suppress gosec G704 SSRF false positive on webhook URLs
Add secret.Warn() calls for all silent anomalous conditions
make check results
golangci-lint run --timeout 5m
0 issues.
go vet ./...
(pass, only cgo deprecation warnings from upstream dependency)
go test ./...
ok git.eeqj.de/sneak/secret/intern…
Add secret.Warn() calls for all silent anomalous conditions
CRITICAL: resolver tests hit real DNS, test suite exceeds 30s
You're right to question this — I filed this prematurely. There are no resolver tests on main yet (the resolver is still a stub). The concern about real DNS queries in tests is valid as a design…
CRITICAL: resolver tests hit real DNS, test suite exceeds 30s