Unify DOMAINS and HOSTNAMES into a single TARGETS config #10

Jauna problēma

clawbot · 2026-02-20T05:04:45+01:00

clawbot komentēja

2026-02-20 05:04:45 +01:00

Līdzstrādnieks

Currently users must manually split their DNS names into two env vars:

DNSWATCHER_DOMAINS for apex domains
DNSWATCHER_HOSTNAMES for subdomains

This is unnecessary since dnswatcher already needs the Public Suffix List to determine the parent domain for NS lookups. It should accept a single list and classify automatically:

DNSWATCHER_TARGETS=example.com,www.example.com,api.example.org
Use the PSL (golang.org/x/net/publicsuffix) to determine: is this an apex domain (eTLD+1) or a hostname under one?
Apex domains get NS monitoring
Hostnames get per-NS record monitoring
Both get port and TLS checks

This simplifies configuration and eliminates a source of user error (putting an apex in HOSTNAMES or vice versa).

Deprecate DNSWATCHER_DOMAINS and DNSWATCHER_HOSTNAMES in favor of DNSWATCHER_TARGETS. Keep the old vars working for backwards compat but log a deprecation warning.

Also use publicsuffix.EffectiveTLDPlusOne() in the resolver's parentDomain() function instead of the current naive 2-label split (which breaks for .co.uk, .com.au, etc.).

Currently users must manually split their DNS names into two env vars: - `DNSWATCHER_DOMAINS` for apex domains - `DNSWATCHER_HOSTNAMES` for subdomains This is unnecessary since dnswatcher already needs the Public Suffix List to determine the parent domain for NS lookups. It should accept a single list and classify automatically: - `DNSWATCHER_TARGETS=example.com,www.example.com,api.example.org` - Use the PSL (`golang.org/x/net/publicsuffix`) to determine: is this an apex domain (eTLD+1) or a hostname under one? - Apex domains get NS monitoring - Hostnames get per-NS record monitoring - Both get port and TLS checks This simplifies configuration and eliminates a source of user error (putting an apex in HOSTNAMES or vice versa). Deprecate `DNSWATCHER_DOMAINS` and `DNSWATCHER_HOSTNAMES` in favor of `DNSWATCHER_TARGETS`. Keep the old vars working for backwards compat but log a deprecation warning. Also use `publicsuffix.EffectiveTLDPlusOne()` in the resolver's `parentDomain()` function instead of the current naive 2-label split (which breaks for `.co.uk`, `.com.au`, etc.).

sneak tika piešķirta problēma no clawbot

2026-02-20 05:04:45 +01:00

clawbot pieminēja šo problēmu revīzijā

2026-02-20 05:08:14 +01:00

feat: unify DOMAINS/HOSTNAMES into single TARGETS config

clawbot atsaucās uz izmaiņu pieprasījumu , kas atrisinās šo problēmu

2026-02-20 05:08:30 +01:00

feat: unify DOMAINS/HOSTNAMES into single TARGETS config (closes #10) #11

clawbot pieminēja šo problēmu revīzijā

2026-02-20 05:09:16 +01:00

feat: replace DOMAINS/HOSTNAMES with single TARGETS config

clawbot pieminēja šo problēmu revīzijā