feat: unify DOMAINS/HOSTNAMES into single TARGETS config (closes #10) #11

Sapludināts

sneak sapludināja 2 revīzijas no feature/unified-targets uz main 2026-02-20 09:05:00 +01:00

Saruna 1 Revīzijas 2 Izmainītie faili 7 +248 -35

clawbot komentēja 2026-02-20 05:08:30 +01:00

Līdzstrādnieks

Kopēt saiti

Summary

Replaces DNSWATCHER_DOMAINS and DNSWATCHER_HOSTNAMES with a single DNSWATCHER_TARGETS env var. Names are automatically classified as apex domains or hostnames using the Public Suffix List (golang.org/x/net/publicsuffix). No backwards compatibility — old vars are removed entirely (pre-1.0).

Changes

• internal/config/classify.go: ClassifyDNSName() and ClassifyTargets() using publicsuffix.EffectiveTLDPlusOne()
• internal/config/classify_test.go: 11 test cases
• internal/config/config.go: Replaced DOMAINS/HOSTNAMES with TARGETS, removed all legacy/deprecation logic
• README.md: Added pre-1.0 warning, updated env var table, removed old vars

Classification

Input	Result
example.com	domain
www.example.com	hostname
example.co.uk	domain
api.example.co.uk	hostname
co.uk	error (public suffix)

Test Results

All 12 tests pass. No new lint issues (only pre-existing gosec in notify.go). Build succeeds.

Closes #10

## Summary Replaces `DNSWATCHER_DOMAINS` and `DNSWATCHER_HOSTNAMES` with a single `DNSWATCHER_TARGETS` env var. Names are automatically classified as apex domains or hostnames using the Public Suffix List (`golang.org/x/net/publicsuffix`). No backwards compatibility — old vars are removed entirely (pre-1.0). ## Changes - **`internal/config/classify.go`**: `ClassifyDNSName()` and `ClassifyTargets()` using `publicsuffix.EffectiveTLDPlusOne()` - **`internal/config/classify_test.go`**: 11 test cases - **`internal/config/config.go`**: Replaced DOMAINS/HOSTNAMES with TARGETS, removed all legacy/deprecation logic - **`README.md`**: Added pre-1.0 warning, updated env var table, removed old vars ## Classification | Input | Result | |-------|--------| | `example.com` | domain | | `www.example.com` | hostname | | `example.co.uk` | domain | | `api.example.co.uk` | hostname | | `co.uk` | error (public suffix) | ## Test Results All 12 tests pass. No new lint issues (only pre-existing gosec in notify.go). Build succeeds. Closes #10

sneak tika piešķirta problēma no clawbot 2026-02-20 05:08:30 +01:00

clawbot iesūtīja 1 revīziju 2026-02-20 05:08:31 +01:00

feat: unify DOMAINS/HOSTNAMES into single TARGETS config ... 5916e32ff3

Add DNSWATCHER_TARGETS env var that accepts a comma-separated list of
DNS names and automatically classifies them as apex domains or hostnames
using the Public Suffix List (golang.org/x/net/publicsuffix).

- ClassifyDNSName() uses EffectiveTLDPlusOne to determine if a name is
  an apex domain (eTLD+1) or hostname (has more labels than eTLD+1)
- Public suffixes themselves (e.g. co.uk) are rejected with an error
- DNSWATCHER_DOMAINS and DNSWATCHER_HOSTNAMES are preserved for
  backwards compatibility but logged as deprecated
- When both TARGETS and legacy vars are set, results are merged with
  deduplication

Closes #10

clawbot veica piespiedu izmaiņu iesūtīšanu atzarā feature/unified-targets no revīzijas 5916e32ff3 uz 628bba22fe 2026-02-20 05:09:16 +01:00 Salīdzināt

clawbot veica piespiedu izmaiņu iesūtīšanu atzarā feature/unified-targets no revīzijas 628bba22fe uz 73e01c7664 2026-02-20 05:09:45 +01:00 Salīdzināt

clawbot iesūtīja 1 revīziju 2026-02-20 08:43:46 +01:00

fix: resolve gosec SSRF findings and formatting issues ... f8d5a8f6cc

Validate webhook/ntfy URLs at Service construction time and add
targeted nolint directives for pre-validated URL usage.

sneak saplidināta revīzija 5e4631776a atzarā main 2026-02-20 09:05:00 +01:00

sneak pieminēja šo problēmu revīzijā 2026-02-20 09:05:02 +01:00

Merge pull request 'feat: unify DOMAINS/HOSTNAMES into single TARGETS config (closes #10)' (#11) from feature/unified-targets into main

clawbot komentēja 2026-02-20 09:07:03 +01:00

Autors

Līdzstrādnieks

Kopēt saiti

make check passes ✅

==> Checking formatting...
==> Running linter...
==> Running tests...
PASS ok sneak.berlin/go/dnswatcher/internal/config 1.280s
==> Building...
==> All checks passed!

make check passes ✅ ``` ==> Checking formatting... ==> Running linter... ==> Running tests... PASS ok sneak.berlin/go/dnswatcher/internal/config 1.280s ==> Building... ==> All checks passed! ```

Nepieciešams pieteikties, lai pievienotos šai sarunai.

Recenzenti

No Reviewers

Iezīmes

Noņemt iezīmes

bot

Agent's turn to work

merge-ready

All checks pass, reviewed, rebased, ready for merge

needs-checks

make check does not pass cleanly

needs-rebase

PR has merge conflicts or is behind main

needs-review

Code review not yet done

needs-rework

Code review found issues to fix

Nav iezīmju

Atskaites punkts

Nav vienumu

Nav atskaites punktu

Projekti

Notīrīt projektus

Nav projektu

Atbildīgie

Noņemt atbildīgo

clawbot sneak

Nav atbildīgo sneak

1 dalībnieki

Paziņojumi

Abonēt

Izpildes termiņš

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Atsaucas uz: sneak/dnswatcher#11