sneak/pixa
1
0
Fork 0
Code Issues 48 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix: check negative cache in Service.Get() before fetching upstream (closes #3) #8

Merged
sneak merged 2 commits from fix/issue-3 into main 2026-02-09 01:32:27 +01:00
Conversation 1 Commits 2 Files Changed 2
+116
clawbot commented 2026-02-09 01:00:15 +01:00
Collaborator
Copy Link
Copy Source
No description provided.
sneak was assigned by clawbot 2026-02-09 01:00:15 +01:00
clawbot added 1 commit 2026-02-09 01:00:15 +01:00
fix: check negative cache in Service.Get() before fetching upstream 5690dc39f4 
The checkNegativeCache() method existed but was never called, making
negative caching (for failed fetches) completely non-functional.
Failed URLs were being re-fetched on every request.

Add negative cache check at the start of Service.Get() to short-circuit
requests for recently-failed URLs.

Fixes #3
clawbot force-pushed fix/issue-3 from 5690dc39f4 to e651e672aa 2026-02-09 01:02:36 +01:00 Compare
clawbot commented 2026-02-09 01:11:19 +01:00
Author
Collaborator
Copy Link
Copy Source

Test only (no fix): FAIL

# sneak.berlin/go/pixa/internal/imgcache [sneak.berlin/go/pixa/internal/imgcache.test]
internal/imgcache/negative_cache_test.go:96:9: undefined: ErrNegativeCached
internal/imgcache/negative_cache_test.go:97:21: undefined: ErrNegativeCached
FAIL	sneak.berlin/go/pixa/internal/imgcache [build failed]
FAIL

Test + fix: PASS

ok  	sneak.berlin/go/pixa/internal/config
ok  	sneak.berlin/go/pixa/internal/encurl
ok  	sneak.berlin/go/pixa/internal/handlers
ok  	sneak.berlin/go/pixa/internal/imgcache
ok  	sneak.berlin/go/pixa/internal/middleware
ok  	sneak.berlin/go/pixa/internal/seal
ok  	sneak.berlin/go/pixa/internal/session
### Test only (no fix): FAIL ``` # sneak.berlin/go/pixa/internal/imgcache [sneak.berlin/go/pixa/internal/imgcache.test] internal/imgcache/negative_cache_test.go:96:9: undefined: ErrNegativeCached internal/imgcache/negative_cache_test.go:97:21: undefined: ErrNegativeCached FAIL sneak.berlin/go/pixa/internal/imgcache [build failed] FAIL ``` ### Test + fix: PASS ``` ok sneak.berlin/go/pixa/internal/config ok sneak.berlin/go/pixa/internal/encurl ok sneak.berlin/go/pixa/internal/handlers ok sneak.berlin/go/pixa/internal/imgcache ok sneak.berlin/go/pixa/internal/middleware ok sneak.berlin/go/pixa/internal/seal ok sneak.berlin/go/pixa/internal/session ```
sneak added 1 commit 2026-02-09 01:32:19 +01:00
Merge branch 'main' into fix/issue-3 3d857da237
sneak merged commit b800ef86d8 into main 2026-02-09 01:32:27 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees sneak
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#8