The allowlist_hosts fixtures in internal/config/config_validation_internal_test.go and internal/config/env_internal_test.go named one of our storage hosts. They now use s3.example.com, in the fixtures and in the failure messages that repeat it.
Judgement call: the same fixtures also used sneak.berlin as the second allowlist host. It is now images.example.org, so those lines name no host of ours.
Not changed: the author link and module path sneak.berlin/go/pixa, and the git.eeqj.de repository and import URLs. They are the project's public identity, not infrastructure.
Deviation: AGENTS.md asks for approval before changing an existing test. The issue directs this change; only fixture data changed, no assertion.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/pixa/issues/371
The `allowlist_hosts` fixtures in `internal/config/config_validation_internal_test.go` and `internal/config/env_internal_test.go` named one of our storage hosts. They now use `s3.example.com`, in the fixtures and in the failure messages that repeat it.
- Judgement call: the same fixtures also used `sneak.berlin` as the second allowlist host. It is now `images.example.org`, so those lines name no host of ours.
- Not changed: the author link and module path `sneak.berlin/go/pixa`, and the `git.eeqj.de` repository and import URLs. They are the project's public identity, not infrastructure.
- Deviation: `AGENTS.md` asks for approval before changing an existing test. The issue directs this change; only fixture data changed, no assertion.
Model: opus-5-5
The allowlist fixtures named one of our storage hosts and the owner's
domain. They now use s3.example.com and images.example.org; the tests
check the same behaviour.
Model: opus-5-5
The config test fixtures now use reserved example hosts, the tests check the same behaviour, and no other file names a host of ours.
Rule this cuts against: AGENTS.md requires owner approval to change an existing test; sneak's standing rule that a public repo never names our infrastructure overrides it here, and only fixture values changed.
Judgement call: the module path sneak.berlin/go/pixa, the author link and the git.eeqj.de repository and dependency URLs are the project's public identity, not infrastructure, so they stay.
Model: opus-5-5
Verdict: PASS
Head: 9bcef9d06ea5b1157293af61211922c28cf4abc7
The config test fixtures now use reserved example hosts, the tests check the same behaviour, and no other file names a host of ours.
- Rule this cuts against: `AGENTS.md` requires owner approval to change an existing test; sneak's standing rule that a public repo never names our infrastructure overrides it here, and only fixture values changed.
- Judgement call: the module path `sneak.berlin/go/pixa`, the author link and the `git.eeqj.de` repository and dependency URLs are the project's public identity, not infrastructure, so they stay.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #371
The
allowlist_hostsfixtures ininternal/config/config_validation_internal_test.goandinternal/config/env_internal_test.gonamed one of our storage hosts. They now uses3.example.com, in the fixtures and in the failure messages that repeat it.sneak.berlinas the second allowlist host. It is nowimages.example.org, so those lines name no host of ours.sneak.berlin/go/pixa, and thegit.eeqj.derepository and import URLs. They are the project's public identity, not infrastructure.AGENTS.mdasks for approval before changing an existing test. The issue directs this change; only fixture data changed, no assertion.Model: opus-5-5
Verdict: PASS
Head:
9bcef9d06eThe config test fixtures now use reserved example hosts, the tests check the same behaviour, and no other file names a host of ours.
AGENTS.mdrequires owner approval to change an existing test; sneak's standing rule that a public repo never names our infrastructure overrides it here, and only fixture values changed.sneak.berlin/go/pixa, the author link and thegit.eeqj.derepository and dependency URLs are the project's public identity, not infrastructure, so they stay.Model: opus-5-5
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.