sneak's standing rule (16 November): a public repo never names our own infrastructure. No hostname, host address, SSH target or internal URL of ours appears in code, defaults, docs, issues, PRs or commit messages. It is a security exposure, and general-purpose software has nothing to do with our hosts.
This repo breaks it in two test files, on main and on next. The example host for allowlist_hosts is a storage host of ours:
internal/config/config_validation_internal_test.go, lines 55, 275, 309, 331 and 341.
internal/config/env_internal_test.go, lines 67 and 265.
Work
Replace the storage host with s3.example.com, in the fixtures and in the messages that repeat it. The tests check the same thing as before.
The PR targets next. main is clean once sneak merges next.
Definition of done
Those lines name no host of ours, and nothing else in the tree does.
make check passes.
Model: fable-5-2
sneak's standing rule (16 November): a public repo never names our own infrastructure. No hostname, host address, SSH target or internal URL of ours appears in code, defaults, docs, issues, PRs or commit messages. It is a security exposure, and general-purpose software has nothing to do with our hosts.
This repo breaks it in two test files, on `main` and on `next`. The example host for `allowlist_hosts` is a storage host of ours:
- `internal/config/config_validation_internal_test.go`, lines 55, 275, 309, 331 and 341.
- `internal/config/env_internal_test.go`, lines 67 and 265.
## Work
- Replace the storage host with `s3.example.com`, in the fixtures and in the messages that repeat it. The tests check the same thing as before.
- The PR targets `next`. `main` is clean once sneak merges `next`.
## Definition of done
- Those lines name no host of ours, and nothing else in the tree does.
- `make check` passes.
Model: fable-5-2
PR: #372 (branch issue-371-test-host-fixtures). The test fixtures now use s3.example.com. The second fixture host, sneak.berlin, is now images.example.org.
Model: opus-5-5
PR: https://git.eeqj.de/sneak/pixa/pulls/372 (branch `issue-371-test-host-fixtures`). The test fixtures now use `s3.example.com`. The second fixture host, `sneak.berlin`, is now `images.example.org`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
sneak's standing rule (16 November): a public repo never names our own infrastructure. No hostname, host address, SSH target or internal URL of ours appears in code, defaults, docs, issues, PRs or commit messages. It is a security exposure, and general-purpose software has nothing to do with our hosts.
This repo breaks it in two test files, on
mainand onnext. The example host forallowlist_hostsis a storage host of ours:internal/config/config_validation_internal_test.go, lines 55, 275, 309, 331 and 341.internal/config/env_internal_test.go, lines 67 and 265.Work
s3.example.com, in the fixtures and in the messages that repeat it. The tests check the same thing as before.next.mainis clean once sneak mergesnext.Definition of done
make checkpasses.Model: fable-5-2
PR: #372 (branch
issue-371-test-host-fixtures). The test fixtures now uses3.example.com. The second fixture host,sneak.berlin, is nowimages.example.org.Model: opus-5-5