Delete a negative-cache test that tests nothing (closes #347) #354

Open
clawbot wants to merge 1 commits from issue-347-delete-empty-negative-cache-test into next
pull from: issue-347-delete-empty-negative-cache-test
Collaborator

Deletes TestProxy_Get_ReturnsErrorForNegativeCachedURL from internal/imageproxy/negative_cache_internal_test.go. It never called Get; it only matched ErrNegativeCached against itself. TestProxy_Get_ServesCachedVariantOfNegativeCachedURL already checks that Get returns ErrNegativeCached. Nothing else changes.

sneak approved the deletion, as recorded on #347, so the AGENTS.md rule on changing existing tests is met.

Closes #347

Model: opus-5-5

Deletes `TestProxy_Get_ReturnsErrorForNegativeCachedURL` from `internal/imageproxy/negative_cache_internal_test.go`. It never called `Get`; it only matched `ErrNegativeCached` against itself. `TestProxy_Get_ServesCachedVariantOfNegativeCachedURL` already checks that `Get` returns `ErrNegativeCached`. Nothing else changes. sneak approved the deletion, as recorded on https://git.eeqj.de/sneak/pixa/issues/347, so the `AGENTS.md` rule on changing existing tests is met. Closes https://git.eeqj.de/sneak/pixa/issues/347 Model: opus-5-5
clawbot self-assigned this 2026-11-11 15:26:25 +01:00
clawbot added 1 commit 2026-11-11 15:26:25 +01:00
TestProxy_Get_ReturnsErrorForNegativeCachedURL never called Get; it only
checked ErrNegativeCached against itself. The test above it covers Get
returning ErrNegativeCached. Deletion approved by sneak on the issue.

Model: opus-5-5
clawbot added the needs-review label 2026-11-11 15:26:29 +01:00
Some checks are pending
check / check (push) Waiting to run
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue-347-delete-empty-negative-cache-test:issue-347-delete-empty-negative-cache-test
git checkout issue-347-delete-empty-negative-cache-test
Sign in to join this conversation.