TestProxy_Get_ReturnsErrorForNegativeCachedURL in internal/imageproxy/negative_cache_internal_test.go never calls Get. It sets err := ErrNegativeCached and checks that errors.Is matches it against itself, so it tests nothing, and its name and comment say it checks what Get does. The test just above it already checks that Get returns ErrNegativeCached for a URL in the negative cache.
AGENTS.md says an existing test changes only with your approval, so this waits on you.
Question: may this test be deleted?
Recommendation: yes, delete it. The test above already covers what its name claims, so nothing is lost, and no other test changes.
Model: opus-5-5
`TestProxy_Get_ReturnsErrorForNegativeCachedURL` in `internal/imageproxy/negative_cache_internal_test.go` never calls `Get`. It sets `err := ErrNegativeCached` and checks that `errors.Is` matches it against itself, so it tests nothing, and its name and comment say it checks what `Get` does. The test just above it already checks that `Get` returns `ErrNegativeCached` for a URL in the negative cache.
`AGENTS.md` says an existing test changes only with your approval, so this waits on you.
**Question:** may this test be deleted?
**Recommendation:** yes, delete it. The test above already covers what its name claims, so nothing is lost, and no other test changes.
Model: opus-5-5
sneak
was assigned by clawbot2026-10-27 05:08:32 +01:00
Ruled by sneak in chat on 6 November: delete the test, since it checks nothing. A worker removes it in a PR into next, with nothing else changed.
Model: opus-5-5
Ruled by sneak in chat on 6 November: delete the test, since it checks nothing. A worker removes it in a PR into `next`, with nothing else changed.
Model: opus-5-5
sneak
was unassigned by clawbot2026-11-06 18:21:13 +01:00
clawbot
self-assigned this 2026-11-06 18:21:13 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
TestProxy_Get_ReturnsErrorForNegativeCachedURLininternal/imageproxy/negative_cache_internal_test.gonever callsGet. It setserr := ErrNegativeCachedand checks thaterrors.Ismatches it against itself, so it tests nothing, and its name and comment say it checks whatGetdoes. The test just above it already checks thatGetreturnsErrNegativeCachedfor a URL in the negative cache.AGENTS.mdsays an existing test changes only with your approval, so this waits on you.Question: may this test be deleted?
Recommendation: yes, delete it. The test above already covers what its name claims, so nothing is lost, and no other test changes.
Model: opus-5-5
Ruled by sneak in chat on 6 November: delete the test, since it checks nothing. A worker removes it in a PR into
next, with nothing else changed.Model: opus-5-5