"Running under upaas" in README.md listed PIXA_CACHE_MAX_BYTES as optional. Under upaas the volume is a directory on the host's filesystem. The default limit is 75% of the sum of that filesystem's free space and what the cache holds, and at least 500 MiB, so one pixa can grow its cache to three quarters or more of the space the host and every other app have left, and to all of it when that is 500 MiB or less. The section now tells the operator to set the variable and says what the default does there.
The default is unchanged, as the plan on #251 decided. The Deployment section already says to set cache_max_bytes for a lasting deployment and is left as it was.
No test: the change is to documentation only, so no test could fail before it and pass after it.
Model: opus-5-5
"Running under upaas" in `README.md` listed `PIXA_CACHE_MAX_BYTES` as optional. Under upaas the volume is a directory on the host's filesystem. The default limit is 75% of the sum of that filesystem's free space and what the cache holds, and at least 500 MiB, so one pixa can grow its cache to three quarters or more of the space the host and every other app have left, and to all of it when that is 500 MiB or less. The section now tells the operator to set the variable and says what the default does there.
The default is unchanged, as the plan on https://git.eeqj.de/sneak/pixa/issues/251 decided. The Deployment section already says to set `cache_max_bytes` for a lasting deployment and is left as it was.
- No test: the change is to documentation only, so no test could fail before it and pass after it.
Model: opus-5-5
README.md lines 126-130 ("Running under upaas", PIXA_CACHE_MAX_BYTES): the default is given as 75% of the free space plus what the cache holds, with the claim that it lets the cache grow to three quarters of the space left. The default is never below 500 MiB (the Configuration section says so), so on a shared filesystem with less than about 667 MiB free and cached together the cache can take all of the space left, which is the case this warning is for. The TODO.md entry (lines 33-38), the PR body and the commit message say the same, and their wording "75% of that filesystem's free space plus what the cache holds" also reads as 75% of the free space with the cache's bytes added on top. Acceptable: state the default as the Configuration section does (75% of the sum of the free space and what the cache holds, at least 500 MiB) and make the "three quarters" claim hold when the minimum applies, in all four places.
Model: opus-5-5
Review failed: `needs-rework`.
1. `README.md` lines 126-130 ("Running under upaas", `PIXA_CACHE_MAX_BYTES`): the default is given as 75% of the free space plus what the cache holds, with the claim that it lets the cache grow to three quarters of the space left. The default is never below 500 MiB (the Configuration section says so), so on a shared filesystem with less than about 667 MiB free and cached together the cache can take all of the space left, which is the case this warning is for. The `TODO.md` entry (lines 33-38), the PR body and the commit message say the same, and their wording "75% of that filesystem's free space plus what the cache holds" also reads as 75% of the free space with the cache's bytes added on top. Acceptable: state the default as the Configuration section does (75% of the sum of the free space and what the cache holds, at least 500 MiB) and make the "three quarters" claim hold when the minimum applies, in all four places.
Model: opus-5-5
Fixed: README, TODO.md, PR body and commit message now give the default as 75% of the sum of the free space and what the cache holds, and at least 500 MiB, and say the cache can take three quarters or more of the space left, and all of it when that is 500 MiB or less.
Model: opus-5-5
1. Fixed: README, `TODO.md`, PR body and commit message now give the default as 75% of the sum of the free space and what the cache holds, and at least 500 MiB, and say the cache can take three quarters or more of the space left, and all of it when that is 500 MiB or less.
Model: opus-5-5
TODO.md, Completed Steps: the branch no longer merges into the current next. Since it was pushed, next has gained four entries at the top of Completed Steps, for #254, #244, #245 and #246. The tracker reports a conflict in TODO.md, and a local rebase, which uses git's union merge, puts this change's entry below those four. Acceptable: rebase onto the current next and keep one copy of this change's entry, at the top of Completed Steps.
Disclosures:
Judgement call: I read "the space they all have left" in README.md as the free space plus what the cache already holds. Read that way, the sentence matches the code.
Model: opus-5-5
Review failed: needs-rework.
1. `TODO.md`, Completed Steps: the branch no longer merges into the current `next`. Since it was pushed, `next` has gained four entries at the top of Completed Steps, for https://git.eeqj.de/sneak/pixa/issues/254, https://git.eeqj.de/sneak/pixa/issues/244, https://git.eeqj.de/sneak/pixa/issues/245 and https://git.eeqj.de/sneak/pixa/issues/246. The tracker reports a conflict in `TODO.md`, and a local rebase, which uses git's union merge, puts this change's entry below those four. Acceptable: rebase onto the current `next` and keep one copy of this change's entry, at the top of Completed Steps.
Disclosures:
- Judgement call: I read "the space they all have left" in `README.md` as the free space plus what the cache already holds. Read that way, the sentence matches the code.
Model: opus-5-5
"Running under upaas" listed PIXA_CACHE_MAX_BYTES as optional. Under
upaas the volume is a directory on the host's filesystem. The default,
75% of the sum of that filesystem's free space and what the cache
holds, and at least 500 MiB, lets one pixa take three quarters or more
of the space the host and every other app have left, and all of it
when that is 500 MiB or less. The section now says to set it and why.
The default is unchanged.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
"Running under upaas" in
README.mdlistedPIXA_CACHE_MAX_BYTESas optional. Under upaas the volume is a directory on the host's filesystem. The default limit is 75% of the sum of that filesystem's free space and what the cache holds, and at least 500 MiB, so one pixa can grow its cache to three quarters or more of the space the host and every other app have left, and to all of it when that is 500 MiB or less. The section now tells the operator to set the variable and says what the default does there.The default is unchanged, as the plan on #251 decided. The Deployment section already says to set
cache_max_bytesfor a lasting deployment and is left as it was.Model: opus-5-5
Review failed:
needs-rework.README.mdlines 126-130 ("Running under upaas",PIXA_CACHE_MAX_BYTES): the default is given as 75% of the free space plus what the cache holds, with the claim that it lets the cache grow to three quarters of the space left. The default is never below 500 MiB (the Configuration section says so), so on a shared filesystem with less than about 667 MiB free and cached together the cache can take all of the space left, which is the case this warning is for. TheTODO.mdentry (lines 33-38), the PR body and the commit message say the same, and their wording "75% of that filesystem's free space plus what the cache holds" also reads as 75% of the free space with the cache's bytes added on top. Acceptable: state the default as the Configuration section does (75% of the sum of the free space and what the cache holds, at least 500 MiB) and make the "three quarters" claim hold when the minimum applies, in all four places.Model: opus-5-5
8f5abb0b3eto4350b1657cTODO.md, PR body and commit message now give the default as 75% of the sum of the free space and what the cache holds, and at least 500 MiB, and say the cache can take three quarters or more of the space left, and all of it when that is 500 MiB or less.Model: opus-5-5
Review failed: needs-rework.
TODO.md, Completed Steps: the branch no longer merges into the currentnext. Since it was pushed,nexthas gained four entries at the top of Completed Steps, for #254, #244, #245 and #246. The tracker reports a conflict inTODO.md, and a local rebase, which uses git's union merge, puts this change's entry below those four. Acceptable: rebase onto the currentnextand keep one copy of this change's entry, at the top of Completed Steps.Disclosures:
README.mdas the free space plus what the cache already holds. Read that way, the sentence matches the code.Model: opus-5-5
4350b1657cto23328551adRebased onto
next; no file conflicted, and onlyTODO.mdneeded its entry moved back to the top of Completed Steps.Model: opus-5-5