configs/config.example.yml allowlisted github.com and user-images.githubusercontent.com, where anyone can put an image. A deployment set up as Getting Started says therefore served every image there to anyone without a signature, at any size and in any format. The example now leaves allowlist_hosts out and shows one commented entry, images.example.com. Getting Started and "Running under upaas" in README.md say that every image on an allowlisted host is served without a signature, so an allowlisted host must be one the operator controls; the comment above the key in the example config says the same.
The new test TestExampleConfigAllowlistsNoHost in internal/config loads the example file itself (../../configs/config.example.yml, which the Docker test stage has, as .dockerignore leaves configs/ in) with PIXA_SIGNING_KEY set, the way Getting Started has the file copied and its key replaced. It fails if the example allowlists any host again.
Judgement call: the key is commented out rather than written as allowlist_hosts: [], as the file already does for referer_blocklist and blocked_networks, whose default is also none; uncommenting both lines gives a working entry.
Model: opus-5-5
`configs/config.example.yml` allowlisted `github.com` and `user-images.githubusercontent.com`, where anyone can put an image. A deployment set up as Getting Started says therefore served every image there to anyone without a signature, at any size and in any format. The example now leaves `allowlist_hosts` out and shows one commented entry, `images.example.com`. Getting Started and "Running under upaas" in `README.md` say that every image on an allowlisted host is served without a signature, so an allowlisted host must be one the operator controls; the comment above the key in the example config says the same.
The new test `TestExampleConfigAllowlistsNoHost` in `internal/config` loads the example file itself (`../../configs/config.example.yml`, which the Docker test stage has, as `.dockerignore` leaves `configs/` in) with `PIXA_SIGNING_KEY` set, the way Getting Started has the file copied and its key replaced. It fails if the example allowlists any host again.
Issue: https://git.eeqj.de/sneak/pixa/issues/249
- Judgement call: the key is commented out rather than written as `allowlist_hosts: []`, as the file already does for `referer_blocklist` and `blocked_networks`, whose default is also none; uncommenting both lines gives a working entry.
Model: opus-5-5
Loads configs/config.example.yml with a real signing key, as Getting
Started has it copied and edited, and fails while the example allowlists
any host: every image on an allowlisted host is served to anyone without
a signature. Fails until
#249 is fixed.
Model: opus-5-5
configs/config.example.yml allowlisted github.com and
user-images.githubusercontent.com, where anyone can put an image, so a
deployment set up as Getting Started says served those images to anyone
without a signature. The example now leaves allowlist_hosts out, with
one commented entry under example.com. Getting Started and "Running
under upaas" in README.md say that every image on an allowlisted host
is served without a signature, so an allowlisted host must be one the
operator controls.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
configs/config.example.ymlallowlistedgithub.comanduser-images.githubusercontent.com, where anyone can put an image. A deployment set up as Getting Started says therefore served every image there to anyone without a signature, at any size and in any format. The example now leavesallowlist_hostsout and shows one commented entry,images.example.com. Getting Started and "Running under upaas" inREADME.mdsay that every image on an allowlisted host is served without a signature, so an allowlisted host must be one the operator controls; the comment above the key in the example config says the same.The new test
TestExampleConfigAllowlistsNoHostininternal/configloads the example file itself (../../configs/config.example.yml, which the Docker test stage has, as.dockerignoreleavesconfigs/in) withPIXA_SIGNING_KEYset, the way Getting Started has the file copied and its key replaced. It fails if the example allowlists any host again.Issue: #249
allowlist_hosts: [], as the file already does forreferer_blocklistandblocked_networks, whose default is also none; uncommenting both lines gives a working entry.Model: opus-5-5
Review passed: the example config allowlists no host and the README says an allowlisted host must be one the operator controls.
Model: opus-5-5