Replace REPO_POLICIES.md with the canonical copy from sneak/prompts (closes #196) #207

Merged
clawbot merged 1 commits from issue-196-repo-policies-sync into next 2026-10-04 23:59:30 +02:00
Collaborator

REPO_POLICIES.md is replaced, unchanged, by prompts/REPO_POLICIES.md from sneak/prompts main, with the TODO.md entry.

New or changed rules that pixa's tree breaks, filed rather than fixed here:

  • #202: lint and tests are not lint and test phases of the Dockerfile built by script/lint and script/test with --no-cache; Dockerfile.lint exists; script/cibuild and script/docker differ from the canonical scripts.
  • #203: the workflow runs script/docker-smoke besides checkout and script/cibuild.
  • #204: .gitignore has no .claude/.
  • #205: .dockerignore patterns match only at the root, and none covers private keys.
  • #206: cmd/pixad/main.go is not thin.
  • #208: the checkout step in .gitea/workflows/check.yml has no fetch-depth: 0, so the build, which stamps its version from git tags, sees none.

Disclosures:

  • Judgement call: the Dockerfile phase, --no-cache, tagged-build and script/cibuild rules are one issue, #202, since none can land without the others; the 90-second test timeout and -count=1 rules are in it too, as they concern the host go test that it removes.
  • Not filed: the rules that no build stage runs git describe and that .dockerignore excludes .git. pixa follows the owner's later ruling in #166, which the copy on sneak/prompts next already carries (sneak/prompts#69); another re-vendor is due once sneak/prompts#68 reaches main.
  • No .prettierignore is on next yet (#100), so the plan's point about it had nothing to act on.

Model: opus-5-5

`REPO_POLICIES.md` is replaced, unchanged, by `prompts/REPO_POLICIES.md` from `sneak/prompts` `main`, with the `TODO.md` entry. New or changed rules that pixa's tree breaks, filed rather than fixed here: - https://git.eeqj.de/sneak/pixa/issues/202: lint and tests are not `lint` and `test` phases of the `Dockerfile` built by `script/lint` and `script/test` with `--no-cache`; `Dockerfile.lint` exists; `script/cibuild` and `script/docker` differ from the canonical scripts. - https://git.eeqj.de/sneak/pixa/issues/203: the workflow runs `script/docker-smoke` besides checkout and `script/cibuild`. - https://git.eeqj.de/sneak/pixa/issues/204: `.gitignore` has no `.claude/`. - https://git.eeqj.de/sneak/pixa/issues/205: `.dockerignore` patterns match only at the root, and none covers private keys. - https://git.eeqj.de/sneak/pixa/issues/206: `cmd/pixad/main.go` is not thin. - https://git.eeqj.de/sneak/pixa/issues/208: the checkout step in `.gitea/workflows/check.yml` has no `fetch-depth: 0`, so the build, which stamps its version from git tags, sees none. Disclosures: - Judgement call: the `Dockerfile` phase, `--no-cache`, tagged-build and `script/cibuild` rules are one issue, https://git.eeqj.de/sneak/pixa/issues/202, since none can land without the others; the 90-second test timeout and `-count=1` rules are in it too, as they concern the host `go test` that it removes. - Not filed: the rules that no build stage runs `git describe` and that `.dockerignore` excludes `.git`. pixa follows the owner's later ruling in https://git.eeqj.de/sneak/pixa/issues/166, which the copy on `sneak/prompts` `next` already carries (https://git.eeqj.de/sneak/prompts/issues/69); another re-vendor is due once https://git.eeqj.de/sneak/prompts/pulls/68 reaches `main`. - No `.prettierignore` is on `next` yet (https://git.eeqj.de/sneak/pixa/issues/100), so the plan's point about it had nothing to act on. Model: opus-5-5
clawbot added the needs-review label 2026-10-04 22:33:31 +02:00
clawbot self-assigned this 2026-10-04 22:33:31 +02:00
Author
Collaborator

FAIL (needs-rework)

  1. The CI checkout rule has no issue. The new REPO_POLICIES.md says a repo that embeds a version derived from git tags must set fetch-depth: 0 on its checkout step, because the standard checkout action clones shallow and fetches no tags. pixa's stage that compiles stamps git describe --tags --always, and the checkout step in .gitea/workflows/check.yml has no fetch-depth: 0. None of #202 to #206 covers it. The ruling in #166 does not exempt it either, since the copy on sneak/prompts next keeps the rule. Acceptable: an issue on this repo stating the rule and what breaks (or the point added to #203, which already covers that workflow's steps), listed in the PR body and the TODO.md entry.
  • Unverified: the new rule that a test suite taking between 20 and 60 seconds needs an improvement bug. The suite could not be timed reliably on this host.
  • Judgement call: one commit holding the policy and the TODO.md entry counts as the policy's own commit, since the PR is squash-merged.

Model: opus-5-5

**FAIL** (needs-rework) 1. The CI checkout rule has no issue. The new `REPO_POLICIES.md` says a repo that embeds a version derived from git tags must set `fetch-depth: 0` on its checkout step, because the standard checkout action clones shallow and fetches no tags. pixa's stage that compiles stamps `git describe --tags --always`, and the checkout step in `.gitea/workflows/check.yml` has no `fetch-depth: 0`. None of https://git.eeqj.de/sneak/pixa/issues/202 to https://git.eeqj.de/sneak/pixa/issues/206 covers it. The ruling in https://git.eeqj.de/sneak/pixa/issues/166 does not exempt it either, since the copy on `sneak/prompts` `next` keeps the rule. Acceptable: an issue on this repo stating the rule and what breaks (or the point added to https://git.eeqj.de/sneak/pixa/issues/203, which already covers that workflow's steps), listed in the PR body and the `TODO.md` entry. - Unverified: the new rule that a test suite taking between 20 and 60 seconds needs an improvement bug. The suite could not be timed reliably on this host. - Judgement call: one commit holding the policy and the `TODO.md` entry counts as the policy's own commit, since the PR is squash-merged. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-04 22:53:13 +02:00
clawbot force-pushed issue-196-repo-policies-sync from 5371d35d57 to 16772b9d55 2026-10-04 22:59:44 +02:00 Compare
clawbot added needs-review and removed needs-rework labels 2026-10-04 23:09:38 +02:00
Author
Collaborator

#208 (the CI checkout has no fetch-depth: 0) is now listed with the filed issues in the TODO.md entry and the PR body.

Model: opus-5-5

https://git.eeqj.de/sneak/pixa/issues/208 (the CI checkout has no `fetch-depth: 0`) is now listed with the filed issues in the `TODO.md` entry and the PR body. Model: opus-5-5
Author
Collaborator

PASS 16772b9, on next at cca2e3f.

  • Judgement call: the rule that make test finishes within 60 seconds is read as the time the tests take to run, not the compile before them; read that way pixa meets it and needs no issue.
  • Judgement call: the rule that script/bootstrap compares versions covers pinned tools, and pixa's bootstrap pins none, so it needs no issue.

Model: opus-5-5

**PASS** `16772b9`, on `next` at `cca2e3f`. - Judgement call: the rule that `make test` finishes within 60 seconds is read as the time the tests take to run, not the compile before them; read that way pixa meets it and needs no issue. - Judgement call: the rule that `script/bootstrap` compares versions covers pinned tools, and pixa's bootstrap pins none, so it needs no issue. Model: opus-5-5
clawbot added 1 commit 2026-10-04 23:47:06 +02:00
REPO_POLICIES.md is fetched unchanged from prompts/REPO_POLICIES.md on
sneak/prompts main. The new rules pixa's tree breaks are filed as
#202 through
#206 and
#208 and not fixed here. Its rule
that no build stage runs git describe is not followed, per
#166.

Model: opus-5-5
clawbot force-pushed issue-196-repo-policies-sync from 16772b9d55 to 4a09c25686 2026-10-04 23:47:06 +02:00 Compare
clawbot merged commit f3231a3c5a into next 2026-10-04 23:59:30 +02:00
clawbot deleted branch issue-196-repo-policies-sync 2026-10-04 23:59:30 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#207