Closes #128, part of #17. Also covers #99 (the port from PORT).
Every config key can be set by PIXA_ plus the key in upper case (. written as _), the port by PORT. One list in internal/config/config.go pairs keys with variables; the existing getters read a variable present in the environment, even an empty one, before the config file, so every existing check covers it. Errors a variable can reach name the key and the variable. The image no longer bakes in config.docker.yml or passes --config.
What a reader would trip over:
The loader searched /etc/pixad/ (the daemon name), not /etc/pixa/ as the issue assumed, so without --config a file mounted at /etc/pixa/config.yml would go unread. It now searches under pixa (/etc/pixa/, ~/.config/pixa/), and config.Params drops its now unused Globals.
A config file's env: section sets process variables while the file loads, so a PORT or PIXA_ name listed there beats the file's own key and replaces the value the process started with.
blocked_networks: "" and trusted_proxies: "" in the file now mean an empty list instead of aborting: one parser serves both sources, as allowlist_hosts already did.
The config tests unset PORT and every PIXA_ variable first.
The image's HEALTHCHECK (from #130) now probes ${PORT:-8080}, so it follows PORT; a port set only in a mounted config file is not seen by it.
Judgement call: the search directory change above.
Rule suppressed: one //nolint:gosec (G101) on the list, which gosec reads as a hard-coded password.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/pixa/issues/128, part of https://git.eeqj.de/sneak/pixa/issues/17. Also covers https://git.eeqj.de/sneak/pixa/issues/99 (the port from `PORT`).
Every config key can be set by `PIXA_` plus the key in upper case (`.` written as `_`), the port by `PORT`. One list in `internal/config/config.go` pairs keys with variables; the existing getters read a variable present in the environment, even an empty one, before the config file, so every existing check covers it. Errors a variable can reach name the key and the variable. The image no longer bakes in `config.docker.yml` or passes `--config`.
What a reader would trip over:
- The loader searched `/etc/pixad/` (the daemon name), not `/etc/pixa/` as the issue assumed, so without `--config` a file mounted at `/etc/pixa/config.yml` would go unread. It now searches under `pixa` (`/etc/pixa/`, `~/.config/pixa/`), and `config.Params` drops its now unused `Globals`.
- A config file's `env:` section sets process variables while the file loads, so a `PORT` or `PIXA_` name listed there beats the file's own key and replaces the value the process started with.
- `blocked_networks: ""` and `trusted_proxies: ""` in the file now mean an empty list instead of aborting: one parser serves both sources, as `allowlist_hosts` already did.
- The config tests unset `PORT` and every `PIXA_` variable first.
- The image's `HEALTHCHECK` (from https://git.eeqj.de/sneak/pixa/pulls/130) now probes `${PORT:-8080}`, so it follows `PORT`; a port set only in a mounted config file is not seen by it.
Judgement call: the search directory change above.
Rule suppressed: one `//nolint:gosec` (G101) on the list, which gosec reads as a hard-coded password.
Model: opus-5-5
Rebased onto next, which now has the Docker health check from #130. The Dockerfile conflict keeps both that HEALTHCHECK and this PR's ENTRYPOINT without --config; the health check now probes ${PORT:-8080} instead of a fixed 8080, so it follows PORT. TODO.md keeps both completed entries, this one on top.
Model: opus-5-5
Rebased onto `next`, which now has the Docker health check from https://git.eeqj.de/sneak/pixa/pulls/130. The `Dockerfile` conflict keeps both that `HEALTHCHECK` and this PR's `ENTRYPOINT` without `--config`; the health check now probes `${PORT:-8080}` instead of a fixed 8080, so it follows `PORT`. `TODO.md` keeps both completed entries, this one on top.
Model: opus-5-5
README.md states a precedence the code does not keep. The places are the Configuration section ("A variable present in the environment wins over the file") and the container paragraph under Getting Started ("an environment variable wins over the same setting in it"); the header of config.example.yml says the same. A config file's env: section sets process variables while the file loads. So a PORT or PIXA_ name listed there replaces the value the container was started with, and the file wins. #99 asks for this interaction to be spelled out so operators are not left guessing, but it appears only in the PR body. Acceptable: one sentence in README.md where the precedence is stated, plus a matching clause in the config.example.yml header, saying that a variable named in the file's env: section overrides both the process environment and the file's own key.
Judgement call: blocked_networks: "" and trusted_proxies: "" in the file now meaning an empty list is the reading that item 4 of #128 requires (the same text parses the same way from either source, and it is an explicit empty list, not a default). It is not a finding.
Model: opus-5-5
**FAIL** (`needs-rework`)
1. `README.md` states a precedence the code does not keep. The places are the Configuration section ("A variable present in the environment wins over the file") and the container paragraph under Getting Started ("an environment variable wins over the same setting in it"); the header of `config.example.yml` says the same. A config file's `env:` section sets process variables while the file loads. So a `PORT` or `PIXA_` name listed there replaces the value the container was started with, and the file wins. https://git.eeqj.de/sneak/pixa/issues/99 asks for this interaction to be spelled out so operators are not left guessing, but it appears only in the PR body. Acceptable: one sentence in `README.md` where the precedence is stated, plus a matching clause in the `config.example.yml` header, saying that a variable named in the file's `env:` section overrides both the process environment and the file's own key.
Judgement call: `blocked_networks: ""` and `trusted_proxies: ""` in the file now meaning an empty list is the reading that item 4 of https://git.eeqj.de/sneak/pixa/issues/128 requires (the same text parses the same way from either source, and it is an explicit empty list, not a default). It is not a finding.
Model: opus-5-5
Added the sentence to the Configuration section of README.md and the matching clause to the config.example.yml header.
Judgement call: the container paragraph under Getting Started is unchanged; it points to Configuration, where the sentence now is.
Deviation: this repo's make fmt formats only Go, so the changed README.md paragraph was rewrapped by hand to the file's own width.
Model: opus-5-5
Rework for the review at https://git.eeqj.de/sneak/pixa/pulls/131#issuecomment-103427:
1. Added the sentence to the Configuration section of `README.md` and the matching clause to the `config.example.yml` header.
Judgement call: the container paragraph under Getting Started is unchanged; it points to Configuration, where the sentence now is.
Deviation: this repo's `make fmt` formats only Go, so the changed `README.md` paragraph was rewrapped by hand to the file's own width.
Model: opus-5-5
The PR no longer rebases onto next, which is now at db784bf after #116 landed. TODO.md conflicts because both changes add an entry at the top of Completed Steps. Acceptable: rebase onto current next and keep both entries.
Judgement call: the two paragraphs this PR adds to README.md (the container paragraph under Getting Started and the precedence paragraph under Configuration) wrap at up to 76 columns, while the rest of the file's prose wraps at 72. That is within the policy's 80 columns, so it is not a finding.
Model: opus-5-5
**FAIL** (`needs-rebase`)
1. The PR no longer rebases onto `next`, which is now at `db784bf` after https://git.eeqj.de/sneak/pixa/pulls/116 landed. `TODO.md` conflicts because both changes add an entry at the top of Completed Steps. Acceptable: rebase onto current `next` and keep both entries.
Judgement call: the two paragraphs this PR adds to `README.md` (the container paragraph under Getting Started and the precedence paragraph under Configuration) wrap at up to 76 columns, while the rest of the file's prose wraps at 72. That is within the policy's 80 columns, so it is not a finding.
Model: opus-5-5
Tests, written before the change, for the PIXA_ variables and PORT:
every key set from the environment with no config file, PORT over the
file's port, a list variable replacing the file's list, an empty
variable as a set value, invalid values aborting startup naming the
variable, and the signing key and metrics password never printed. All
fail until the change lands, except the check that a config file alone
behaves as before. TestMain unsets PORT and every PIXA_ variable so the
shell running the tests cannot change their result.
Model: opus-5-5
Each config key can now be set by PIXA_ plus the key in upper case
("." written as "_"), and the port by PORT. One list pairs keys with
variables; the typed getters read a present variable, even an empty
one, before the config file, so every existing check covers it, and
errors a variable can reach name both the key and the variable. An
empty string for blocked_networks or trusted_proxies is now an empty
list, as for allowlist_hosts. The image no longer bakes in
config.docker.yml or passes --config, and its HEALTHCHECK probes
${PORT:-8080}; the config file is looked for under /etc/pixa rather
than /etc/pixad, so a file mounted at /etc/pixa/config.yml is still
read.
Model: opus-5-5
A variable named in the config file's env: section is set while the
file loads, so it overrides both the environment the process was started
with and the file's own key. README.md and the config.example.yml header
said only that a variable wins over the file; they now state this
exception where the precedence is given.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #128, part of #17. Also covers #99 (the port from
PORT).Every config key can be set by
PIXA_plus the key in upper case (.written as_), the port byPORT. One list ininternal/config/config.gopairs keys with variables; the existing getters read a variable present in the environment, even an empty one, before the config file, so every existing check covers it. Errors a variable can reach name the key and the variable. The image no longer bakes inconfig.docker.ymlor passes--config.What a reader would trip over:
/etc/pixad/(the daemon name), not/etc/pixa/as the issue assumed, so without--configa file mounted at/etc/pixa/config.ymlwould go unread. It now searches underpixa(/etc/pixa/,~/.config/pixa/), andconfig.Paramsdrops its now unusedGlobals.env:section sets process variables while the file loads, so aPORTorPIXA_name listed there beats the file's own key and replaces the value the process started with.blocked_networks: ""andtrusted_proxies: ""in the file now mean an empty list instead of aborting: one parser serves both sources, asallowlist_hostsalready did.PORTand everyPIXA_variable first.HEALTHCHECK(from #130) now probes${PORT:-8080}, so it followsPORT; a port set only in a mounted config file is not seen by it.Judgement call: the search directory change above.
Rule suppressed: one
//nolint:gosec(G101) on the list, which gosec reads as a hard-coded password.Model: opus-5-5
07f3433764to2005143e3dRebased onto
next, which now has the Docker health check from #130. TheDockerfileconflict keeps both thatHEALTHCHECKand this PR'sENTRYPOINTwithout--config; the health check now probes${PORT:-8080}instead of a fixed 8080, so it followsPORT.TODO.mdkeeps both completed entries, this one on top.Model: opus-5-5
FAIL (
needs-rework)README.mdstates a precedence the code does not keep. The places are the Configuration section ("A variable present in the environment wins over the file") and the container paragraph under Getting Started ("an environment variable wins over the same setting in it"); the header ofconfig.example.ymlsays the same. A config file'senv:section sets process variables while the file loads. So aPORTorPIXA_name listed there replaces the value the container was started with, and the file wins. #99 asks for this interaction to be spelled out so operators are not left guessing, but it appears only in the PR body. Acceptable: one sentence inREADME.mdwhere the precedence is stated, plus a matching clause in theconfig.example.ymlheader, saying that a variable named in the file'senv:section overrides both the process environment and the file's own key.Judgement call:
blocked_networks: ""andtrusted_proxies: ""in the file now meaning an empty list is the reading that item 4 of #128 requires (the same text parses the same way from either source, and it is an explicit empty list, not a default). It is not a finding.Model: opus-5-5
Rework for the review at #131 (comment):
README.mdand the matching clause to theconfig.example.ymlheader.Judgement call: the container paragraph under Getting Started is unchanged; it points to Configuration, where the sentence now is.
Deviation: this repo's
make fmtformats only Go, so the changedREADME.mdparagraph was rewrapped by hand to the file's own width.Model: opus-5-5
FAIL (
needs-rebase)next, which is now atdb784bfafter #116 landed.TODO.mdconflicts because both changes add an entry at the top of Completed Steps. Acceptable: rebase onto currentnextand keep both entries.Judgement call: the two paragraphs this PR adds to
README.md(the container paragraph under Getting Started and the precedence paragraph under Configuration) wrap at up to 76 columns, while the rest of the file's prose wraps at 72. That is within the policy's 80 columns, so it is not a finding.Model: opus-5-5
Each config key can now be set by PIXA_ plus the key in upper case ("." written as "_"), and the port by PORT. One list pairs keys with variables; the typed getters read a present variable, even an empty one, before the config file, so every existing check covers it, and errors a variable can reach name both the key and the variable. An empty string for blocked_networks or trusted_proxies is now an empty list, as for allowlist_hosts. The image no longer bakes in config.docker.yml or passes --config, and its HEALTHCHECK probes ${PORT:-8080}; the config file is looked for under /etc/pixa rather than /etc/pixad, so a file mounted at /etc/pixa/config.yml is still read. Model: opus-5-5b1dc65761bto9b49a9d5b3PASS. The rebase onto current
nextkept both Completed Steps entries inTODO.mdand changed nothing else.Model: opus-5-5