All review comments have been addressed:
- README relative paths — fixed to absolute URLs
- No separate types package —
internal/domainremoved entirely - "domain" bad name…
Re comments 4 & 5:
ContainerLogs already uses ContainerID in its signature (updated in the types refactor). All our wrapper methods (StartContainer, StopContainer, RemoveContainer,…
Checked CODE_STYLEGUIDE_GO.md — it didn't have a rule about type-only packages. Created PR to add one: sneak/prompts#1
Eliminated the internal/domain package entirely. Types now live alongside their implementations:
ImageID+ContainerID→internal/docker/types.goUnparsedURL→ `internal/service/w…
To clarify: c.docker is *client.Client from the Docker SDK (github.com/docker/docker/client). Its methods (ContainerStart, ContainerStop, ContainerLogs, ContainerInspect, etc.) all…
Fixed in 5c43d5b: ContainerLogs on our docker.Client wrapper already takes docker.ContainerID (previously domain.ContainerID, now the type lives in the docker package directly). The tail…
Fixed in 5c43d5b: The domain package (and its import alias) no longer exists. Types are defined directly in the packages that use them, so there's no domain name anywhere.
Fixed in 5c43d5b: Removed the internal/domain types package entirely. ImageID and ContainerID are now defined in internal/docker/ alongside the Docker client that uses them. UnparsedURL…
Fixed: removed the ./data relative path default from HOST_DATA_DIR in the docker-compose example. The variable now has no default — users must explicitly set it to an absolute host path…
eaf8d18a55
Merge pull request 'fix: pin ruby base by sha256, add wrangler+prettier, use apt-get (closes #1)' (#2) from feature/pin-and-add-deps into main