SetTopic, KickUser and BroadcastMode in internal/service/service.go fan the TOPIC, KICK and MODE message out to every channel member, the issuer included. The IRC listener's handleTopic, handleKick and applyChannelModes (internal/ircserver/commands.go) also write an echo to the issuer's connection. The relay (internal/ircserver/relay.go) drops a user's own PRIVMSG, NOTICE, JOIN, PART, NICK and QUIT, but deliverTopicChange, deliverKickMsg and deliverMode have no such check, so the issuer gets the line twice.
Seen on eceb5f2 with alice and carl on #dup over the IRC listener. alice sends TOPIC #dup :new topic and receives
MODE #dup +m gives her two MODE lines and KICK #dup carl :bye two KICK lines, the relayed copy sometimes before the echo. carl receives each once. An IRC client shows every topic change, mode change and kick its user makes twice.
README.md (MODE, "On the IRC listener") describes the double delivery for MODE: "echoed to the operator's connection and also sent to every channel member, the operator included".
Fix: in relay.go, skip a TOPIC, KICK or MODE whose from is the connection's own nick, with the one own-nick check the other five already use. The direct echo stays, since it carries the real hostmask and arrives in order. A change made from another client of the same session then reaches the IRC connection no more than a PRIVMSG from that client does today. The README MODE sentence changes to say the operator gets one line.
Definition of done
An IRC listener user who sets a topic, changes a channel mode or kicks gets exactly one TOPIC, MODE or KICK line; the other members still get theirs once.
Tests in internal/ircserver that count the lines for each of the three.
README.md MODE no longer describes a second copy.
One reviewed PR against next.
Model: fable-5-1
`SetTopic`, `KickUser` and `BroadcastMode` in `internal/service/service.go` fan the TOPIC, KICK and MODE message out to every channel member, the issuer included. The IRC listener's `handleTopic`, `handleKick` and `applyChannelModes` (`internal/ircserver/commands.go`) also write an echo to the issuer's connection. The relay (`internal/ircserver/relay.go`) drops a user's own PRIVMSG, NOTICE, JOIN, PART, NICK and QUIT, but `deliverTopicChange`, `deliverKickMsg` and `deliverMode` have no such check, so the issuer gets the line twice.
Seen on `eceb5f2` with `alice` and `carl` on `#dup` over the IRC listener. alice sends `TOPIC #dup :new topic` and receives
```
:alice!alice@localhost TOPIC #dup :new topic
:alice!alice@* TOPIC #dup :new topic
```
`MODE #dup +m` gives her two MODE lines and `KICK #dup carl :bye` two KICK lines, the relayed copy sometimes before the echo. carl receives each once. An IRC client shows every topic change, mode change and kick its user makes twice.
`README.md` (MODE, "On the IRC listener") describes the double delivery for MODE: "echoed to the operator's connection and also sent to every channel member, the operator included".
Fix: in `relay.go`, skip a TOPIC, KICK or MODE whose `from` is the connection's own nick, with the one own-nick check the other five already use. The direct echo stays, since it carries the real hostmask and arrives in order. A change made from another client of the same session then reaches the IRC connection no more than a PRIVMSG from that client does today. The README MODE sentence changes to say the operator gets one line.
## Definition of done
1. An IRC listener user who sets a topic, changes a channel mode or kicks gets exactly one TOPIC, MODE or KICK line; the other members still get theirs once.
2. Tests in `internal/ircserver` that count the lines for each of the three.
3. `README.md` MODE no longer describes a second copy.
4. One reviewed PR against `next`.
Model: fable-5-1
clawbot
self-assigned this 2026-10-20 16:51:33 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
SetTopic,KickUserandBroadcastModeininternal/service/service.gofan the TOPIC, KICK and MODE message out to every channel member, the issuer included. The IRC listener'shandleTopic,handleKickandapplyChannelModes(internal/ircserver/commands.go) also write an echo to the issuer's connection. The relay (internal/ircserver/relay.go) drops a user's own PRIVMSG, NOTICE, JOIN, PART, NICK and QUIT, butdeliverTopicChange,deliverKickMsganddeliverModehave no such check, so the issuer gets the line twice.Seen on
eceb5f2withaliceandcarlon#dupover the IRC listener. alice sendsTOPIC #dup :new topicand receivesMODE #dup +mgives her two MODE lines andKICK #dup carl :byetwo KICK lines, the relayed copy sometimes before the echo. carl receives each once. An IRC client shows every topic change, mode change and kick its user makes twice.README.md(MODE, "On the IRC listener") describes the double delivery for MODE: "echoed to the operator's connection and also sent to every channel member, the operator included".Fix: in
relay.go, skip a TOPIC, KICK or MODE whosefromis the connection's own nick, with the one own-nick check the other five already use. The direct echo stays, since it carries the real hostmask and arrives in order. A change made from another client of the same session then reaches the IRC connection no more than a PRIVMSG from that client does today. The README MODE sentence changes to say the operator gets one line.Definition of done
internal/ircserverthat count the lines for each of the three.README.mdMODE no longer describes a second copy.next.Model: fable-5-1