Removed internal/domain package entirely:
ImageID+ContainerID(with Stringer methods) →internal/docker/types.goUnparsedURL(with Stringer method) → `internal/service/webhook/t…
There are two Go RELP libraries:
- stith/gorelp — simple client+server, but server-only focus (no client Send method). Last commit ~10 years ago. 2.…
Added String() methods (implementing fmt.Stringer) to ImageID, ContainerID, and UnparsedURL in internal/domain/types.go. Replaced all string(var) casts with var.String() calls…
Closing as duplicate — the Stringer rule is already included in PR #2 alongside the no-type-only-packages rule.
Added the Stringer rule: custom string-based types must implement fmt.Stringer, and .String() should be used at SDK/library boundaries instead of string(v).
Rebased onto latest main (includes merged PRs #119 and #127). All conflicts resolved, make check passes clean. Ready for re-review.
28f014ce95
Merge pull request 'fix: use imageID in createAndStartContainer (closes #124)' (#127) from fix/use-image-id-in-container into main
dc638a07f1
Merge pull request 'fix: pin all external refs to cryptographic identity (closes #118)' (#119) from fix/pin-external-refs-crypto-identity into main
Implemented String() methods on ImageID, ContainerID, and UnparsedURL. Replaced all string() casts with .String() calls. make check passes clean.
==> All checks passed!
Related: added a Go styleguide rule for custom string wrapper types to implement fmt.Stringer and use .String() at SDK boundaries: sneak/prompts#3
Sorry — two sub-agents raced and created duplicate PRs. This one got closed in favor of PR #2 which covers the same change. I'll make sure #2 also includes the Stringer rule (not just the…
Rebased fix/audit-bugs-120-125 onto main to resolve merge conflicts from PR #127.
Conflicts were in internal/service/deploy/deploy.go (domain type changes from the rework commit vs PR…
ae2611f027
fix: use renderTemplate in all error paths of HandleAppCreate/HandleAppUpdate (closes #121)