Transaction history rows and the Type line on TransactionDetail. SWAP_METHODS in src/shared/transactions.js labels a call "Swap" when the explorer names its method execute, multicall, swap or one of the router swap methods, whatever address it was sent to.
What happens
A call named execute or multicall to any contract, such as a multisig, a smart account or a governance contract, is listed in history as "Swap" and shown with Type "Swap". After #579 the approval screen shows such a call as raw data, while history still calls it a swap.
What should happen
As for #520: a call is described as a swap only when it went to a Uniswap router address known for the network. Any other call is labelled by its method name, as calls outside the list already are.
Severity: minor
Definition of done
History and TransactionDetail label execute and multicall calls "Swap" only when sent to a router address known for the active network, using the same list as the approval screen; other calls show their method name.
Tests cover the same method sent to a router and to another address.
Model: opus-5-5
Seen by the worker on https://git.eeqj.de/sneak/AutistMask/issues/520 (https://git.eeqj.de/sneak/AutistMask/pulls/579).
## Where
Transaction history rows and the Type line on TransactionDetail. `SWAP_METHODS` in `src/shared/transactions.js` labels a call "Swap" when the explorer names its method `execute`, `multicall`, `swap` or one of the router swap methods, whatever address it was sent to.
## What happens
A call named `execute` or `multicall` to any contract, such as a multisig, a smart account or a governance contract, is listed in history as "Swap" and shown with Type "Swap". After https://git.eeqj.de/sneak/AutistMask/pulls/579 the approval screen shows such a call as raw data, while history still calls it a swap.
## What should happen
As for https://git.eeqj.de/sneak/AutistMask/issues/520: a call is described as a swap only when it went to a Uniswap router address known for the network. Any other call is labelled by its method name, as calls outside the list already are.
Severity: minor
## Definition of done
- [ ] History and TransactionDetail label `execute` and `multicall` calls "Swap" only when sent to a router address known for the active network, using the same list as the approval screen; other calls show their method name.
- [ ] Tests cover the same method sent to a router and to another address.
Model: opus-5-5
clawbot
self-assigned this 2026-10-19 03:16:49 +02:00
Plan: one PR to next. In parseTx() in src/shared/transactions.js, a call named execute or multicall is labelled "Swap" only when it was sent to a Universal Router address known for the network the transaction is on (its chainId, which parseTx() already takes), using routerRelease() from src/shared/uniswap.js, the list the approval screen uses (exported for this); any other such call is labelled by its method name, as calls outside the list already are. The named router swap methods keep their label. TransactionDetail's Type line follows from the same history entry. Jest tests with the same method sent to a router and to another address, failing on next.
Model: opus-5-5
Plan: one PR to `next`. In `parseTx()` in `src/shared/transactions.js`, a call named `execute` or `multicall` is labelled "Swap" only when it was sent to a Universal Router address known for the network the transaction is on (its `chainId`, which `parseTx()` already takes), using `routerRelease()` from `src/shared/uniswap.js`, the list the approval screen uses (exported for this); any other such call is labelled by its method name, as calls outside the list already are. The named router swap methods keep their label. TransactionDetail's Type line follows from the same history entry. Jest tests with the same method sent to a router and to another address, failing on `next`.
Model: opus-5-5
Implemented in #643: history and the TransactionDetail Type line call an execute or multicall a Swap only when it was sent to a Universal Router on the network the transaction is on. Any other such call shows its method name.
Model: opus-5-5
Implemented in https://git.eeqj.de/sneak/AutistMask/pulls/643: history and the TransactionDetail Type line call an `execute` or `multicall` a Swap only when it was sent to a Universal Router on the network the transaction is on. Any other such call shows its method name.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Seen by the worker on #520 (#579).
Where
Transaction history rows and the Type line on TransactionDetail.
SWAP_METHODSinsrc/shared/transactions.jslabels a call "Swap" when the explorer names its methodexecute,multicall,swapor one of the router swap methods, whatever address it was sent to.What happens
A call named
executeormulticallto any contract, such as a multisig, a smart account or a governance contract, is listed in history as "Swap" and shown with Type "Swap". After #579 the approval screen shows such a call as raw data, while history still calls it a swap.What should happen
As for #520: a call is described as a swap only when it went to a Uniswap router address known for the network. Any other call is labelled by its method name, as calls outside the list already are.
Severity: minor
Definition of done
executeandmulticallcalls "Swap" only when sent to a router address known for the active network, using the same list as the approval screen; other calls show their method name.Model: opus-5-5
Plan: one PR to
next. InparseTx()insrc/shared/transactions.js, a call namedexecuteormulticallis labelled "Swap" only when it was sent to a Universal Router address known for the network the transaction is on (itschainId, whichparseTx()already takes), usingrouterRelease()fromsrc/shared/uniswap.js, the list the approval screen uses (exported for this); any other such call is labelled by its method name, as calls outside the list already are. The named router swap methods keep their label. TransactionDetail's Type line follows from the same history entry. Jest tests with the same method sent to a router and to another address, failing onnext.Model: opus-5-5
Implemented in #643: history and the TransactionDetail Type line call an
executeormulticalla Swap only when it was sent to a Universal Router on the network the transaction is on. Any other such call shows its method name.Model: opus-5-5