In history (parseTx() in src/shared/transactions.js), a call named execute or multicall is labelled Swap only when it was sent to a Universal Router address listed for the network the transaction is on. That is the transaction's own chain id, not the active network. The check uses routerRelease(), now exported from src/shared/uniswap.js, so it is the same list the approval screen decodes swaps for. Any other such call is labelled by its method name (Execute, Multicall). TransactionDetail's Type line reads that label, so it shows Contract Call. The named router swap methods (swap, swapExactTokensForTokens and the rest) keep their label wherever they were sent.
What the diff does not show:
Such a call's history row now names the contract it was sent to as the counterparty, as other contract calls do, instead of the user's own address.
A multicall to Uniswap's older SwapRouter02 now reads Multicall and Contract Call: only Universal Router addresses are on the list, as the issue asks.
The tests in tests/uniswapRouterAddress.test.js build each row with the real history parser and open it on TransactionDetail. Each method is sent to a router on its network, to another contract, and to a router of the other network only. README's TransactionDetail Type bullet states the rule.
Judgement call: swap stays a Swap wherever it was sent, although other contracts use that name too; the plan keeps it out of this issue.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/AutistMask/issues/580.
In history (`parseTx()` in `src/shared/transactions.js`), a call named `execute` or `multicall` is labelled Swap only when it was sent to a Universal Router address listed for the network the transaction is on. That is the transaction's own chain id, not the active network. The check uses `routerRelease()`, now exported from `src/shared/uniswap.js`, so it is the same list the approval screen decodes swaps for. Any other such call is labelled by its method name (`Execute`, `Multicall`). TransactionDetail's Type line reads that label, so it shows Contract Call. The named router swap methods (`swap`, `swapExactTokensForTokens` and the rest) keep their label wherever they were sent.
What the diff does not show:
- Such a call's history row now names the contract it was sent to as the counterparty, as other contract calls do, instead of the user's own address.
- A `multicall` to Uniswap's older SwapRouter02 now reads `Multicall` and Contract Call: only Universal Router addresses are on the list, as the issue asks.
The tests in `tests/uniswapRouterAddress.test.js` build each row with the real history parser and open it on TransactionDetail. Each method is sent to a router on its network, to another contract, and to a router of the other network only. README's TransactionDetail Type bullet states the rule.
Judgement call: `swap` stays a Swap wherever it was sent, although other contracts use that name too; the plan keeps it out of this issue.
Model: opus-5-5
The history labelled any call named execute or multicall a Swap, whatever
contract it went to, so a multisig or smart account call showed as a Swap
in the list and on TransactionDetail's Type line. Such a call is now a Swap
only when sent to a Universal Router address listed for the network the
transaction is on, the list the approval screen uses (routerRelease(), now
exported from uniswap.js). Any other is labelled by its method name and its
Type line reads Contract Call. The named router swap methods keep their
label.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #580.
In history (
parseTx()insrc/shared/transactions.js), a call namedexecuteormulticallis labelled Swap only when it was sent to a Universal Router address listed for the network the transaction is on. That is the transaction's own chain id, not the active network. The check usesrouterRelease(), now exported fromsrc/shared/uniswap.js, so it is the same list the approval screen decodes swaps for. Any other such call is labelled by its method name (Execute,Multicall). TransactionDetail's Type line reads that label, so it shows Contract Call. The named router swap methods (swap,swapExactTokensForTokensand the rest) keep their label wherever they were sent.What the diff does not show:
multicallto Uniswap's older SwapRouter02 now readsMulticalland Contract Call: only Universal Router addresses are on the list, as the issue asks.The tests in
tests/uniswapRouterAddress.test.jsbuild each row with the real history parser and open it on TransactionDetail. Each method is sent to a router on its network, to another contract, and to a router of the other network only. README's TransactionDetail Type bullet states the rule.Judgement call:
swapstays a Swap wherever it was sent, although other contracts use that name too; the plan keeps it out of this issue.Model: opus-5-5
clawbot referenced this pull request2026-10-20 17:08:06 +02:00
Review: PASS
Model: opus-5-5