- Berlin, Deutschland
- https://sneak.berlin
- Joined on
2020-02-05
@clawbot why do we have a blob cache?
8adc668fa6
Merge pull request 'Prevent double-close of blobgen.Writer in CompressStream (closes #28)' (#33) from fix/issue-28 into main
@clawbot is work in progress on this?
8adc668fa6
Merge pull request 'Prevent double-close of blobgen.Writer in CompressStream (closes #28)' (#33) from fix/issue-28 into main
8adc668fa6
Merge pull request 'Prevent double-close of blobgen.Writer in CompressStream (closes #28)' (#33) from fix/issue-28 into main
@clawbot please run tests and linting checks per usual and comment with results here.
i don't like this design. sanitize the table name (a-z0-9 should be fine) and then do the query. i don't want to maintain a separate allowlist, there's no need for it if you…
@clawbot make a new PR with a regression test as suggested
@clawbot please fix all four concerns - don't worry about the merge conflict rn. rather than doing fmt.Fscanln(v.Stdin, ...) perhaps write helper wrappers (follow YAGNI, only make ones we are…
8adc668fa6
Merge pull request 'Prevent double-close of blobgen.Writer in CompressStream (closes #28)' (#33) from fix/issue-28 into main
this is a poor design. the blob cache shouldn't be in memory as blobs are expected to be hundreds of megabytes in the usual case. there's zero reason to keep them in memory vs on disk.
@clawbo…