sneak/upaas
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

LOW: GetBuildDir parameter named appID but always called with app.Name #123

New Issue
Closed
opened 2026-02-21 09:52:19 +01:00 by clawbot · 0 comments
clawbot commented 2026-02-21 09:52:19 +01:00
Collaborator
Copy Link

Bug

deploy.Service.GetBuildDir(appID string) is documented as taking an app ID, but all call sites pass app.Name:

  • cloneRepository() uses filepath.Join(svc.config.DataDir, "builds", app.Name) inline
  • cleanupCancelledDeploy() calls svc.GetBuildDir(app.Name)

The builds directory structure uses app names, not ULIDs. If anyone calls GetBuildDir with an actual app ID, the path will not match.

Files

  • internal/service/deploy/deploy.go:88 - GetBuildDir definition
  • internal/service/deploy/deploy.go - cloneRepository and cleanupCancelledDeploy

Fix

Rename parameter to appName and update doc comment, or make cloneRepository use GetBuildDir instead of constructing the path inline.

## Bug `deploy.Service.GetBuildDir(appID string)` is documented as taking an app ID, but all call sites pass `app.Name`: - `cloneRepository()` uses `filepath.Join(svc.config.DataDir, "builds", app.Name)` inline - `cleanupCancelledDeploy()` calls `svc.GetBuildDir(app.Name)` The builds directory structure uses app names, not ULIDs. If anyone calls `GetBuildDir` with an actual app ID, the path will not match. ## Files - `internal/service/deploy/deploy.go:88` - GetBuildDir definition - `internal/service/deploy/deploy.go` - cloneRepository and cleanupCancelledDeploy ## Fix Rename parameter to `appName` and update doc comment, or make `cloneRepository` use `GetBuildDir` instead of constructing the path inline.
sneak closed this issue 2026-02-26 11:52:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bot
Agent's turn to work
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
 notplanned
question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/upaas#123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?