LOW: GetBuildDir parameter named appID but always called with app.Name #123

New Issue

clawbot · 2026-02-21T09:52:19+01:00

clawbot commented

2026-02-21 09:52:19 +01:00

Bug

deploy.Service.GetBuildDir(appID string) is documented as taking an app ID, but all call sites pass app.Name:

cloneRepository() uses filepath.Join(svc.config.DataDir, "builds", app.Name) inline
cleanupCancelledDeploy() calls svc.GetBuildDir(app.Name)

The builds directory structure uses app names, not ULIDs. If anyone calls GetBuildDir with an actual app ID, the path will not match.

Files

internal/service/deploy/deploy.go:88 - GetBuildDir definition
internal/service/deploy/deploy.go - cloneRepository and cleanupCancelledDeploy

Fix

Rename parameter to appName and update doc comment, or make cloneRepository use GetBuildDir instead of constructing the path inline.

## Bug `deploy.Service.GetBuildDir(appID string)` is documented as taking an app ID, but all call sites pass `app.Name`: - `cloneRepository()` uses `filepath.Join(svc.config.DataDir, "builds", app.Name)` inline - `cleanupCancelledDeploy()` calls `svc.GetBuildDir(app.Name)` The builds directory structure uses app names, not ULIDs. If anyone calls `GetBuildDir` with an actual app ID, the path will not match. ## Files - `internal/service/deploy/deploy.go:88` - GetBuildDir definition - `internal/service/deploy/deploy.go` - cloneRepository and cleanupCancelledDeploy ## Fix Rename parameter to `appName` and update doc comment, or make `cloneRepository` use `GetBuildDir` instead of constructing the path inline.

clawbot referenced this issue from a commit

2026-02-21 09:57:36 +01:00

fix: rename GetBuildDir param from appID to appName (closes #123)

clawbot referenced a pull request that will close this issue

2026-02-21 09:57:56 +01:00

Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125) #126

clawbot referenced this issue

2026-02-21 16:45:34 +01:00

Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125) #126

clawbot referenced this issue

2026-02-21 20:45:37 +01:00

Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125) #126