sneak/upaas
1
0
Fork 0
Code Issues 10 Pull Requests 3 Actions Packages Projects Releases 1 Wiki Activity

Fix dashboard CSRFField crash (closes #146) #147

Merged
sneak merged 2 commits from fix/dashboard-csrf-field into main 2026-02-26 12:07:43 +01:00
Conversation 2 Commits 2 Files Changed 2 +20 -1
clawbot commented 2026-02-26 11:58:29 +01:00
Collaborator
Copy Link

The dashboard template uses .CSRFField inside a {{range .AppStats}} block. Inside the range, . refers to *handlers.AppStats, not the root template data map. Changed to $.CSRFField to reference the root context.

make check passes. docker build . succeeds.

The dashboard template uses `.CSRFField` inside a `{{range .AppStats}}` block. Inside the range, `.` refers to `*handlers.AppStats`, not the root template data map. Changed to `$.CSRFField` to reference the root context. `make check` passes. `docker build .` succeeds.
sneak was assigned by clawbot 2026-02-26 11:58:29 +01:00
clawbot added 2 commits 2026-02-26 11:58:29 +01:00
test: add failing test for dashboard CSRFField (refs #146) 43cde0eefd
fix: pass CSRFField to dashboard template (closes #146)
All checks were successful
Check / check (pull_request) Successful in 2m30s
Details
c22a2877d5
clawbot commented 2026-02-26 11:58:47 +01:00
Author
Collaborator
Copy Link

Test Results

1. Failing test (test-only commit, before fix)

=== RUN   TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error
template execution failed: "execute page template dashboard.html: template: dashboard.html:72:19: executing "content" at <.CSRFField>: can't evaluate field CSRFField in type *handlers.AppStats"
    handlers_test.go:423: expected: 200, actual: 500
    handlers_test.go:424: "Internal Server Error
" does not contain "csrf-test-app"
--- FAIL: TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error
FAIL

2. Passing test (after fix)

=== RUN   TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error
--- PASS: TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error (0.01s)
PASS
ok  git.eeqj.de/sneak/upaas/internal/handlers  0.226s

3. make check — all passing

==> All checks passed!

4. docker build . — success

Successfully built 8a8c3a64e2a6
## Test Results ### 1. Failing test (test-only commit, before fix) ``` === RUN TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error template execution failed: "execute page template dashboard.html: template: dashboard.html:72:19: executing "content" at <.CSRFField>: can't evaluate field CSRFField in type *handlers.AppStats" handlers_test.go:423: expected: 200, actual: 500 handlers_test.go:424: "Internal Server Error " does not contain "csrf-test-app" --- FAIL: TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error FAIL ``` ### 2. Passing test (after fix) ``` === RUN TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error --- PASS: TestHandleDashboard/renders_dashboard_with_apps_without_CSRFField_error (0.01s) PASS ok git.eeqj.de/sneak/upaas/internal/handlers 0.226s ``` ### 3. `make check` — all passing ``` ==> All checks passed! ``` ### 4. `docker build .` — success ``` Successfully built 8a8c3a64e2a6 ```
clawbot changed title from fix: add CSRFField to dashboard template data (closes #146) to Fix dashboard CSRFField crash (closes #146) 2026-02-26 11:58:57 +01:00
clawbot commented 2026-02-26 11:59:09 +01:00
Author
Collaborator
Copy Link

Test FAILING before fix:

--- FAIL: TestHandleDashboard/renders_dashboard_with_apps_without_crashing_on_CSRFField (0.01s)
    handlers_test.go:422: 
        Error: Not equal: expected: 200, actual: 500
        Messages: dashboard should not 500 when apps exist (CSRFField must be accessible)
    handlers_test.go:423: 
        Error: "Internal Server Error\n" does not contain "csrf-test-app"
FAIL

Test PASSING after fix:

--- PASS: TestHandleDashboard/renders_dashboard_with_apps_without_crashing_on_CSRFField (0.01s)
PASS
ok  git.eeqj.de/sneak/upaas/internal/handlers 0.248s

Linting, formatting, and build all pass: make check exits 0, docker build . succeeds.

**Test FAILING before fix:** ``` --- FAIL: TestHandleDashboard/renders_dashboard_with_apps_without_crashing_on_CSRFField (0.01s) handlers_test.go:422: Error: Not equal: expected: 200, actual: 500 Messages: dashboard should not 500 when apps exist (CSRFField must be accessible) handlers_test.go:423: Error: "Internal Server Error\n" does not contain "csrf-test-app" FAIL ``` **Test PASSING after fix:** ``` --- PASS: TestHandleDashboard/renders_dashboard_with_apps_without_crashing_on_CSRFField (0.01s) PASS ok git.eeqj.de/sneak/upaas/internal/handlers 0.248s ``` **Linting, formatting, and build all pass:** `make check` exits 0, `docker build .` succeeds.
sneak merged commit 019ba7fe1f into main 2026-02-26 12:07:43 +01:00
sneak deleted branch fix/dashboard-csrf-field 2026-02-26 12:07:43 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
 notplanned
question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/upaas#147
Delete Branch "fix/dashboard-csrf-field"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?