Revert "Say that a deploy keeps only an app's volumes when the app has none" #263

Merged
clawbot merged 1 commits from revert-248-no-volumes-warning into next 2026-10-02 01:43:29 +02:00
Collaborator

sneak asked for this in #254 (comment): "this is stupid, revert this entire commit".

This reverts cc786a1e (#248) in full. It removes:

  • the sentence in the app page's Volume Mounts section for an app with no volume mounts
  • the same sentence in each such app's deploy log, and the NoVolumesWarning constant behind both
  • the two tests for them
  • the README sentence that a deploy or rollback keeps only the files in the app's volume mounts
  • its TODO.md entry

One conflict, in TODO.md: later entries were added above the removed one. I kept those (#239, #253, #255) and dropped only the one for #248.

The environment variable hint from #255 keeps its alert-warning class. That class is defined in static/css/input.css and is in the committed static/css/tailwind.css, which the build does not regenerate, so removing the Volume Mounts sentence does not take it out of the stylesheet.

Model: opus-5-5

sneak asked for this in https://git.eeqj.de/sneak/upaas/pulls/254#issuecomment-109763: "this is stupid, revert this entire commit". This reverts `cc786a1e` (https://git.eeqj.de/sneak/upaas/issues/248) in full. It removes: - the sentence in the app page's Volume Mounts section for an app with no volume mounts - the same sentence in each such app's deploy log, and the `NoVolumesWarning` constant behind both - the two tests for them - the README sentence that a deploy or rollback keeps only the files in the app's volume mounts - its `TODO.md` entry One conflict, in `TODO.md`: later entries were added above the removed one. I kept those (https://git.eeqj.de/sneak/upaas/issues/239, https://git.eeqj.de/sneak/upaas/issues/253, https://git.eeqj.de/sneak/upaas/issues/255) and dropped only the one for https://git.eeqj.de/sneak/upaas/issues/248. The environment variable hint from https://git.eeqj.de/sneak/upaas/issues/255 keeps its `alert-warning` class. That class is defined in `static/css/input.css` and is in the committed `static/css/tailwind.css`, which the build does not regenerate, so removing the Volume Mounts sentence does not take it out of the stylesheet. Model: opus-5-5
clawbot added the needs-review label 2026-10-02 01:26:47 +02:00
clawbot self-assigned this 2026-10-02 01:26:47 +02:00
clawbot added 1 commit 2026-10-02 01:26:48 +02:00
This reverts commit cc786a1e84, at the
owner's request. It removes the app page sentence for an app with no
volume mounts, the matching deploy log line and its constant, their
tests, the README sentence and the TODO.md entry. The environment
variable hint keeps its alert-warning class, which is in the committed
stylesheet.

Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit 76858126e2 into next 2026-10-02 01:43:29 +02:00
clawbot deleted branch revert-248-no-volumes-warning 2026-10-02 01:43:29 +02:00
Sign in to join this conversation.