The hint under the app page's environment variable editor said a container restart was needed after changes. Environment variables are set when a container is created. upaas's restart stops and starts the same container, so it keeps the old values. Only a deploy or a rollback creates a new container. The hint's colour class, text-amber-600, is not in the built stylesheet, so the hint showed unstyled.
The hint now reads "Environment variable changes take effect at the next deploy or rollback." It uses alert-warning, the style the same page uses for its Volume Mounts note (added in #248), so the page's two warning sentences look alike. A new handler test renders the app page and checks the hint's wording and style.
The hint still shows only while a variable is being edited, as before.
TODO.md gets its usual Completed Steps entry.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/upaas/issues/255.
The hint under the app page's environment variable editor said a container restart was needed after changes. Environment variables are set when a container is created. upaas's restart stops and starts the same container, so it keeps the old values. Only a deploy or a rollback creates a new container. The hint's colour class, `text-amber-600`, is not in the built stylesheet, so the hint showed unstyled.
The hint now reads "Environment variable changes take effect at the next deploy or rollback." It uses `alert-warning`, the style the same page uses for its Volume Mounts note (added in https://git.eeqj.de/sneak/upaas/issues/248), so the page's two warning sentences look alike. A new handler test renders the app page and checks the hint's wording and style.
- The hint still shows only while a variable is being edited, as before.
- `TODO.md` gets its usual Completed Steps entry.
Model: opus-5-5
The branch conflicts with current next in TODO.md, under Completed Steps, where the entry for #248 landed in the same place. Acceptable: rebased onto current next with both entries kept.
templates/app_detail.html:181: current next already shows a one-sentence warning on this page in alert-warning (the Volume Mounts note added for #248). So the PR body's reason for choosing badge-warning, that this page does not use alert-warning, is no longer true, and the page would show its two warning sentences in two different styles. Acceptable: the hint uses alert-warning like that note, with the test (internal/handlers/app_page_env_var_hint_test.go:37) and the PR body updated to match.
Model: opus-5-5
Review failed.
1. The branch conflicts with current `next` in `TODO.md`, under Completed Steps, where the entry for https://git.eeqj.de/sneak/upaas/issues/248 landed in the same place. Acceptable: rebased onto current `next` with both entries kept.
2. `templates/app_detail.html:181`: current `next` already shows a one-sentence warning on this page in `alert-warning` (the Volume Mounts note added for https://git.eeqj.de/sneak/upaas/issues/248). So the PR body's reason for choosing `badge-warning`, that this page does not use `alert-warning`, is no longer true, and the page would show its two warning sentences in two different styles. Acceptable: the hint uses `alert-warning` like that note, with the test (`internal/handlers/app_page_env_var_hint_test.go:37`) and the PR body updated to match.
Model: opus-5-5
The hint under the app page's environment variable editor asked for a
container restart. Environment variables are set when a container is
created, and upaas's restart stops and starts the same container, so it
keeps the old values; deploy and rollback each create a new container.
The hint now says so in one sentence, styled with alert-warning like the
page's Volume Mounts note: its old text-amber-600 class is not in the
built stylesheet. A handler test renders the app page and checks the
hint.
Model: opus-5-5
Rebased onto current next; TODO.md keeps both Completed Steps entries, this PR's on top.
The hint now uses alert-warning, like the Volume Mounts note on the same page; the test, commit message and PR body say so.
Model: opus-5-5
Rework:
1. Rebased onto current `next`; `TODO.md` keeps both Completed Steps entries, this PR's on top.
2. The hint now uses `alert-warning`, like the Volume Mounts note on the same page; the test, commit message and PR body say so.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #255.
The hint under the app page's environment variable editor said a container restart was needed after changes. Environment variables are set when a container is created. upaas's restart stops and starts the same container, so it keeps the old values. Only a deploy or a rollback creates a new container. The hint's colour class,
text-amber-600, is not in the built stylesheet, so the hint showed unstyled.The hint now reads "Environment variable changes take effect at the next deploy or rollback." It uses
alert-warning, the style the same page uses for its Volume Mounts note (added in #248), so the page's two warning sentences look alike. A new handler test renders the app page and checks the hint's wording and style.TODO.mdgets its usual Completed Steps entry.Model: opus-5-5
Review failed.
The branch conflicts with current
nextinTODO.md, under Completed Steps, where the entry for #248 landed in the same place. Acceptable: rebased onto currentnextwith both entries kept.templates/app_detail.html:181: currentnextalready shows a one-sentence warning on this page inalert-warning(the Volume Mounts note added for #248). So the PR body's reason for choosingbadge-warning, that this page does not usealert-warning, is no longer true, and the page would show its two warning sentences in two different styles. Acceptable: the hint usesalert-warninglike that note, with the test (internal/handlers/app_page_env_var_hint_test.go:37) and the PR body updated to match.Model: opus-5-5
79c1c7fe68tob45ca3d201Rework:
next;TODO.mdkeeps both Completed Steps entries, this PR's on top.alert-warning, like the Volume Mounts note on the same page; the test, commit message and PR body say so.Model: opus-5-5
Review passed.
Model: opus-5-5