clawbot
ef70bb6fa0
check / check (push) Waiting to run
The new package internal/imageproxy holds Proxy, which was imgcache.Service, with its Config, ImageResponse, CacheStatus and errors. imageproxy.New makes and registers the counters of upstream fetches and transforms. internal/imgcache holds the cache only, with its hit and miss counters, and imgcache.CacheConfig is imgcache.Config. The cache reads and writes each kind it keeps with one pair of methods: Variant and PutVariant, Source and PutSource, Failure and PutFailure. Source replaces LookupSource followed by GetSourceContent. imgcache.go and module.go are gone. The proxy's tests moved with it. The cache's tests check that the reconciliation pass removes an empty or cut file and its row. The proxy's tests remove them by hand, then check that Get fetches or converts again. Model: opus-5-5
65 lines
1.8 KiB
Go
65 lines
1.8 KiB
Go
package imgcache
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/prometheus/client_golang/prometheus/testutil"
|
|
)
|
|
|
|
// TestNewCache_RegistersItsCountersOnItsRegistry checks that NewCache
|
|
// registers the cache's counters on the registry it is given, under the
|
|
// names README.md gives them.
|
|
func TestNewCache_RegistersItsCountersOnItsRegistry(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
registry := prometheus.NewRegistry()
|
|
|
|
_, err := NewCache(evictionTestDB(t),
|
|
Config{StateDir: t.TempDir(), MaxBytes: 1 << 30}, registry)
|
|
if err != nil {
|
|
t.Fatalf("NewCache() error = %v", err)
|
|
}
|
|
|
|
names := []string{
|
|
"pixa_cache_hits_total",
|
|
"pixa_cache_misses_total",
|
|
}
|
|
|
|
count, err := testutil.GatherAndCount(registry, names...)
|
|
if err != nil {
|
|
t.Fatalf("testutil.GatherAndCount() error = %v", err)
|
|
}
|
|
|
|
if count != len(names) {
|
|
t.Errorf("%d of the counters %v are on the registry, want %d",
|
|
count, names, len(names))
|
|
}
|
|
}
|
|
|
|
// TestNewCache_FailsWhenItsCountersCannotBeRegistered makes a second cache
|
|
// on the registry of a first. Its counters have the same names, so the
|
|
// registry refuses them, and NewCache must return that error.
|
|
func TestNewCache_FailsWhenItsCountersCannotBeRegistered(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
registry := prometheus.NewRegistry()
|
|
|
|
_, err := NewCache(evictionTestDB(t),
|
|
Config{StateDir: t.TempDir(), MaxBytes: 1 << 30}, registry)
|
|
if err != nil {
|
|
t.Fatalf("NewCache() of the first cache error = %v", err)
|
|
}
|
|
|
|
_, err = NewCache(evictionTestDB(t),
|
|
Config{StateDir: t.TempDir(), MaxBytes: 1 << 30}, registry)
|
|
t.Logf("NewCache() of the second cache error = %v", err)
|
|
|
|
var alreadyRegistered prometheus.AlreadyRegisteredError
|
|
if !errors.As(err, &alreadyRegistered) {
|
|
t.Errorf("NewCache() of the second cache error = %v, want %T",
|
|
err, alreadyRegistered)
|
|
}
|
|
}
|