clawbot
52f69d3082
check / check (push) Waiting to run
The upstream fetch no longer accepts image/svg+xml, and both image routes answer 415, not 500, for any upstream Content-Type outside the source formats. Before decoding, the image processor names the input's format from govips' DetermineImageType and refuses, with 415, input whose first bytes libvips reads as anything but the six source formats, so an SVG passing the first-bytes check for AVIF never reaches librsvg. orig of such an input is refused instead of being saved as JPEG. README.md drops SVG from the source formats. SVG detection stays in internal/magic, unused on the request path, for #168. An AVIF image sequence (brand avis) answers 415. Model: opus-5-5
42 lines
1.3 KiB
Go
42 lines
1.3 KiB
Go
package server
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
|
|
// TestImageProxyRefusesSVG requests an image the upstream answers as SVG,
|
|
// in its own format (orig) and resized as PNG, through pixa's router,
|
|
// upstream fetcher and image processor. pixa does not accept SVG as a
|
|
// source, so each request is answered 415, never with an image.
|
|
func TestImageProxyRefusesSVG(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
upstream := httptest.NewServer(http.HandlerFunc(
|
|
func(w http.ResponseWriter, _ *http.Request) {
|
|
w.Header().Set("Content-Type", "image/svg+xml")
|
|
_, _ = io.WriteString(w, `<svg xmlns="http://www.w3.org/2000/svg" `+
|
|
`width="64" height="48"><rect width="64" height="48"/></svg>`)
|
|
}))
|
|
t.Cleanup(upstream.Close)
|
|
|
|
s, _, _ := startImageProxy(t, upstream)
|
|
|
|
for _, sizeFormat := range []string{"64x48.orig", "32x24.png"} {
|
|
target := "/v1/image/" + upstreamHost + "/drawing.svg/" + sizeFormat
|
|
|
|
rec := httptest.NewRecorder()
|
|
s.ServeHTTP(rec, httptest.NewRequestWithContext(
|
|
t.Context(), http.MethodGet, target, nil))
|
|
t.Logf("GET %s: %d, Content-Type %s, body %s",
|
|
target, rec.Code, rec.Header().Get("Content-Type"), rec.Body.String())
|
|
|
|
if rec.Code != http.StatusUnsupportedMediaType {
|
|
t.Errorf("GET %s status = %d, want %d",
|
|
target, rec.Code, http.StatusUnsupportedMediaType)
|
|
}
|
|
}
|
|
}
|