sneak
adfb6ab50a
check / check (push) Canceled after 0s
magic.DetectFormat returns an imagerequest.Format. ValidateMagicBytes returns the format it checked against the upstream Content-Type. The cache stores that format in the source's row, so a variant made from a cached source uses it too. The proxy hands it to Process, which still refuses input libvips would load with another loader, such as an SVG passing as AVIF. Format.MIMEType declares each MIME string once, and the fetcher, the cache's variant read and the Accept matching use it. magic.MIMEType, magic.ImageFormat, MIMEToImageFormat, magic's SVG detection, detectFormat, formatFromString, FormatToMIME and Result.InputFormat are gone. Model: opus-5-5
110 lines
2.9 KiB
Go
110 lines
2.9 KiB
Go
package imageprocessor
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
"testing"
|
|
"time"
|
|
|
|
"sneak.berlin/go/pixa/internal/imagerequest"
|
|
)
|
|
|
|
// readerAfterDeadline is a Process input whose first Read waits until done
|
|
// is closed, so the deadline passes after Process has taken its slot and
|
|
// before it encodes.
|
|
type readerAfterDeadline struct {
|
|
data *bytes.Reader
|
|
done <-chan struct{}
|
|
waited bool
|
|
}
|
|
|
|
func (r *readerAfterDeadline) Read(p []byte) (int, error) {
|
|
if !r.waited {
|
|
r.waited = true
|
|
|
|
<-r.done
|
|
}
|
|
|
|
return r.data.Read(p)
|
|
}
|
|
|
|
// inputNotToBeRead is a Process input that fails the test when it is read.
|
|
type inputNotToBeRead struct {
|
|
t *testing.T
|
|
}
|
|
|
|
func (r inputNotToBeRead) Read([]byte) (int, error) {
|
|
r.t.Error("Process read its input although its deadline had passed")
|
|
|
|
return 0, io.EOF
|
|
}
|
|
|
|
// TestProcessStopsWhenDeadlinePassed checks that Process returns
|
|
// context.DeadlineExceeded, and holds no slot afterwards, when its context's
|
|
// deadline has passed before it starts, then without reading its input, or
|
|
// while it reads its input. govips gives pixa no way to stop libvips once an
|
|
// encode has begun, so Process must not begin one for a request that has
|
|
// ended.
|
|
func TestProcessStopsWhenDeadlinePassed(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
input := createTestJPEG(t, 50, 50)
|
|
|
|
t.Run("before Process starts", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx, cancel := context.WithDeadline(t.Context(),
|
|
time.Now().Add(-time.Second))
|
|
defer cancel()
|
|
|
|
// With a slot free, the select in acquireSlot takes the slot or sees
|
|
// the ended context at random, so Process is called many times
|
|
for range 100 {
|
|
checkProcessStopsAtDeadline(ctx, t, inputNotToBeRead{t: t})
|
|
}
|
|
})
|
|
|
|
t.Run("while Process reads its input", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx, cancel := context.WithTimeout(t.Context(), 100*time.Millisecond)
|
|
defer cancel()
|
|
|
|
checkProcessStopsAtDeadline(ctx, t, &readerAfterDeadline{
|
|
data: bytes.NewReader(input), done: ctx.Done(),
|
|
})
|
|
})
|
|
}
|
|
|
|
// checkProcessStopsAtDeadline runs Process on input with ctx, whose deadline
|
|
// has passed by the time Process could encode, and fails the test unless
|
|
// Process returns context.DeadlineExceeded and gives its slot back.
|
|
func checkProcessStopsAtDeadline(
|
|
ctx context.Context, t *testing.T, input io.Reader,
|
|
) {
|
|
t.Helper()
|
|
|
|
proc := New(Params{MaxInputBytes: 50 << 20, MaxConcurrentProcessing: 1})
|
|
|
|
result, err := proc.Process(ctx, input, imagerequest.FormatJPEG,
|
|
smallJPEGTransform())
|
|
if result != nil {
|
|
t.Logf("Process() made a %dx%d image after its deadline passed",
|
|
result.Width, result.Height)
|
|
|
|
_ = result.Content.Close()
|
|
}
|
|
|
|
t.Logf("Process() error = %v", err)
|
|
|
|
if !errors.Is(err, context.DeadlineExceeded) {
|
|
t.Errorf("Process() error = %v, want context.DeadlineExceeded", err)
|
|
}
|
|
|
|
if held := len(proc.processingSemaphore); held != 0 {
|
|
t.Errorf("%d slots still held after Process() returned", held)
|
|
}
|
|
}
|