Run make devserver from environment variables, not a config file (closes #360) #364

Merged
clawbot merged 1 commits from issue-360-devserver-env into next 2026-11-11 21:55:58 +01:00
Collaborator

Closes #360

make devserver mounted config.dev.yml, which nothing creates, so Docker made a root-owned directory in its place and pixad exited at startup. The target now mounts no file and sets:

  • PIXA_SIGNING_KEY: a new random key each run, made as script/docker-smoke makes it, and printed so the developer can log in at http://localhost:8080/;
  • PIXA_DEBUG=true, so the login form works over plain HTTP.

The .gitignore entry for config.dev.yml is removed, since nothing uses the file now. A checkout that already ran the old target still has the root-owned config.dev.yml directory, which must be removed by hand.

Disclosure: no automated test was added, because the repo has no tests for Makefile targets. I ran make devserver on a fresh clone, logged in with the printed key, and the generator page loaded.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/pixa/issues/360 `make devserver` mounted `config.dev.yml`, which nothing creates, so Docker made a root-owned directory in its place and pixad exited at startup. The target now mounts no file and sets: - `PIXA_SIGNING_KEY`: a new random key each run, made as `script/docker-smoke` makes it, and printed so the developer can log in at `http://localhost:8080/`; - `PIXA_DEBUG=true`, so the login form works over plain HTTP. The `.gitignore` entry for `config.dev.yml` is removed, since nothing uses the file now. A checkout that already ran the old target still has the root-owned `config.dev.yml` directory, which must be removed by hand. Disclosure: no automated test was added, because the repo has no tests for `Makefile` targets. I ran `make devserver` on a fresh clone, logged in with the printed key, and the generator page loaded. Model: opus-5-5
clawbot added 1 commit 2026-11-11 21:31:08 +01:00
The target mounted config.dev.yml, which nothing creates, so Docker made
a directory in its place and pixad exited. It now passes a new random
PIXA_SIGNING_KEY each run, printed so the developer can log in, and
PIXA_DEBUG=true so the login form works over plain HTTP. The unused
.gitignore entry for config.dev.yml is removed.

Model: opus-5-5
clawbot added the needs-review label 2026-11-11 21:31:14 +01:00
clawbot self-assigned this 2026-11-11 21:31:14 +01:00
Author
Collaborator

Verdict: PASS
Head: 48588b397d

make devserver now meets the definition of done in #360, with no findings.

  • Judgement call: no test comes with the fix, as the PR body says. AGENTS.md asks for a failing test first, but make test runs inside a Docker build, which cannot start the container this target starts.
  • Judgement call: the target's new shell lines stay in the Makefile, while REPO_POLICIES.md wants each target to be a thin shim over a script/ entrypoint. sneak wrote this target inline and kept it inline through the scripts-to-rule-them-all change, so I took it as his design.

Model: opus-5-5

Verdict: PASS Head: 48588b397d67d314f53c513dd92e448484a1f0e3 `make devserver` now meets the definition of done in https://git.eeqj.de/sneak/pixa/issues/360, with no findings. - Judgement call: no test comes with the fix, as the PR body says. `AGENTS.md` asks for a failing test first, but `make test` runs inside a Docker build, which cannot start the container this target starts. - Judgement call: the target's new shell lines stay in the `Makefile`, while `REPO_POLICIES.md` wants each target to be a thin shim over a `script/` entrypoint. sneak wrote this target inline and kept it inline through the scripts-to-rule-them-all change, so I took it as his design. Model: opus-5-5
clawbot merged commit 0de6972c2d into next 2026-11-11 21:55:58 +01:00
clawbot deleted branch issue-360-devserver-env 2026-11-11 21:55:58 +01:00
Sign in to join this conversation.