Keep a variant's accounting row when its file cannot be read (closes #340)

Conversation 1 Commits 2 Files Changed 4

+107 -1

2 Commits

Author	SHA1	Message	Date
clawbot	33045a24b5	Keep a variant's accounting row when its file cannot be read (closes #340 ) check / check (push) Canceled after 0s Details The reconciliation pass dropped a variant's accounting row on any error reading its file's size, and logged every such file as missing. A file still on disk then had no row, so eviction no longer counted it against cache_max_bytes. Now only a missing file (ErrNotFound, which FileStore.Size returns for it) loses its row, with the same info line. Any other error keeps the row and logs a warning naming the variant key and the error, and the pass goes on to the next key. README.md says so under Storage. Model: opus-5-5	2026-10-26 23:56:34 +00:00
clawbot	701ed9b94b	Test that reconciliation drops a variant's row only when its file is missing check / check (push) Canceled after 0s Details reconcileVariantRows is given two tracked variants. The first one's file is a symbolic link to itself, so reading its size fails with an error other than a missing file. The test wants its row kept, with a warning naming its key and the error. The second one has no file, and the test wants its row dropped with the info line for a missing file. The test fails on next, which drops both rows and logs both files as missing. The fix follows in the next commit. Model: opus-5-5	2026-10-26 23:54:24 +00:00

Author

SHA1

Message

Date

clawbot

33045a24b5

Keep a variant's accounting row when its file cannot be read (closes #340 )

check / check (push) Canceled after 0s

Details

The reconciliation pass dropped a variant's accounting row on any error
reading its file's size, and logged every such file as missing. A file
still on disk then had no row, so eviction no longer counted it against
cache_max_bytes. Now only a missing file (ErrNotFound, which
FileStore.Size returns for it) loses its row, with the same info line.
Any other error keeps the row and logs a warning naming the variant key
and the error, and the pass goes on to the next key. README.md says so
under Storage.

Model: opus-5-5

2026-10-26 23:56:34 +00:00

clawbot

701ed9b94b

Test that reconciliation drops a variant's row only when its file is missing

check / check (push) Canceled after 0s

Details

reconcileVariantRows is given two tracked variants. The first one's
file is a symbolic link to itself, so reading its size fails with an
error other than a missing file. The test wants its row kept, with a
warning naming its key and the error. The second one has no file, and
the test wants its row dropped with the info line for a missing file.
The test fails on next, which drops both rows and logs both files as
missing. The fix follows in the next commit.

Model: opus-5-5

2026-10-26 23:54:24 +00:00

Keep a variant's accounting row when its file cannot be read (closes #340) #342