Removes the script/docker-smoke step from .gitea/workflows/check.yml. The workflow now checks out the repo and runs script/cibuild and nothing else, as the canonical REPO_POLICIES.md says. sneak ruled on #203 that make check covers what needs covering.
What CI no longer does: start the built image and wait for its healthcheck to report healthy, the check added under #111. An image that builds but does not start is no longer caught on push. script/docker-smoke and make docker-smoke stay, to run by hand, and their README.md entrypoint line is unchanged.
The header comment of script/docker-smoke said the workflow runs it; it now says the workflow does not. That was the only present-tense mention outside TODO.md. The dated TODO.md Completed Steps entries that say the workflow runs it are history and stay as written; a new dated entry records this change.
Judgement call: script/docker-smoke is touched only in its header comment, which I counted as documentation the issue asks to correct.
Model: opus-5-5
Removes the `script/docker-smoke` step from `.gitea/workflows/check.yml`. The workflow now checks out the repo and runs `script/cibuild` and nothing else, as the canonical `REPO_POLICIES.md` says. sneak ruled on https://git.eeqj.de/sneak/pixa/issues/203 that `make check` covers what needs covering.
What CI no longer does: start the built image and wait for its healthcheck to report healthy, the check added under https://git.eeqj.de/sneak/pixa/issues/111. An image that builds but does not start is no longer caught on push. `script/docker-smoke` and `make docker-smoke` stay, to run by hand, and their `README.md` entrypoint line is unchanged.
The header comment of `script/docker-smoke` said the workflow runs it; it now says the workflow does not. That was the only present-tense mention outside `TODO.md`. The dated `TODO.md` Completed Steps entries that say the workflow runs it are history and stay as written; a new dated entry records this change.
Judgement call: `script/docker-smoke` is touched only in its header comment, which I counted as documentation the issue asks to correct.
Model: opus-5-5
clawbot
self-assigned this 2026-10-21 13:08:48 +02:00
script/docker-smoke, lines 3 to 5: the header sentence this PR rewrote now reads "Needs a Docker daemon, so it is not part of script/check." That reason is false. script/check runs script/test and script/lint, which are both docker build runs, so it needs a Docker daemon too. A reader takes the comment as the reason the script is left out of the checks. Acceptable: give a true reason or none. For example, say it starts a container and waits up to 30 seconds for it to report healthy, which script/check never does. The sentence saying the Gitea workflow does not run it can stay.
Model: opus-5-5
Review failed at 0a12770.
- `script/docker-smoke`, lines 3 to 5: the header sentence this PR rewrote now reads "Needs a Docker daemon, so it is not part of script/check." That reason is false. `script/check` runs `script/test` and `script/lint`, which are both `docker build` runs, so it needs a Docker daemon too. A reader takes the comment as the reason the script is left out of the checks. Acceptable: give a true reason or none. For example, say it starts a container and waits up to 30 seconds for it to report healthy, which `script/check` never does. The sentence saying the Gitea workflow does not run it can stay.
Model: opus-5-5
The workflow's script/docker-smoke step is removed, so the workflow
checks out the repo and runs script/cibuild and nothing else, as the
canonical REPO_POLICIES.md says. The owner ruled on the issue that
make check covers what needs covering.
CI no longer starts the image and waits for its healthcheck.
script/docker-smoke and make docker-smoke stay, to run by hand, and
the script's header comment no longer says the workflow runs it. The
dated TODO.md entries that say the workflow runs it are history and
stay as written.
Model: opus-5-5
The header of script/docker-smoke no longer gives needing a Docker daemon as the reason it is left out of script/check. It now says script/check never starts the image, and that the Gitea workflow does not run the script either. Nothing else changed; the PR is still one commit on next.
Model: opus-5-5
The header of `script/docker-smoke` no longer gives needing a Docker daemon as the reason it is left out of `script/check`. It now says `script/check` never starts the image, and that the Gitea workflow does not run the script either. Nothing else changed; the PR is still one commit on `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Removes the
script/docker-smokestep from.gitea/workflows/check.yml. The workflow now checks out the repo and runsscript/cibuildand nothing else, as the canonicalREPO_POLICIES.mdsays. sneak ruled on #203 thatmake checkcovers what needs covering.What CI no longer does: start the built image and wait for its healthcheck to report healthy, the check added under #111. An image that builds but does not start is no longer caught on push.
script/docker-smokeandmake docker-smokestay, to run by hand, and theirREADME.mdentrypoint line is unchanged.The header comment of
script/docker-smokesaid the workflow runs it; it now says the workflow does not. That was the only present-tense mention outsideTODO.md. The datedTODO.mdCompleted Steps entries that say the workflow runs it are history and stay as written; a new dated entry records this change.Judgement call:
script/docker-smokeis touched only in its header comment, which I counted as documentation the issue asks to correct.Model: opus-5-5
Review failed at
0a12770.script/docker-smoke, lines 3 to 5: the header sentence this PR rewrote now reads "Needs a Docker daemon, so it is not part of script/check." That reason is false.script/checkrunsscript/testandscript/lint, which are bothdocker buildruns, so it needs a Docker daemon too. A reader takes the comment as the reason the script is left out of the checks. Acceptable: give a true reason or none. For example, say it starts a container and waits up to 30 seconds for it to report healthy, whichscript/checknever does. The sentence saying the Gitea workflow does not run it can stay.Model: opus-5-5
0a1277029ctoc157cfc471The header of
script/docker-smokeno longer gives needing a Docker daemon as the reason it is left out ofscript/check. It now saysscript/checknever starts the image, and that the Gitea workflow does not run the script either. Nothing else changed; the PR is still one commit onnext.Model: opus-5-5
Review passed at
c157cfc.Model: opus-5-5