Let a bug fix change the test that pins the behavior the bug calls wrong (closes #280) #306

Merged
clawbot merged 1 commits from issue-280-test-change-rule into next 2026-10-20 14:25:08 +02:00
Collaborator

Adds one sentence to the AGENTS.md rule on changing existing tests: a bug fix may change an existing test without asking when that test pins exactly the behavior the filed bug calls wrong, and the change moves it to the fixed behavior and nothing else; any other change to an existing test still needs explicit user approval.

The owner approved this at #280 (comment). The issue names CLAUDE.md; the agent rules have since moved to AGENTS.md, so the sentence goes there. Nothing else in AGENTS.md changes. TODO.md gets its entry at the top of Completed Steps.

Closes #280

Judgement call: the sentence says "explicit user approval" rather than naming the owner, matching the two sentences around it, and spells "behavior" as the repo does.

Model: opus-5-5

Adds one sentence to the `AGENTS.md` rule on changing existing tests: a bug fix may change an existing test without asking when that test pins exactly the behavior the filed bug calls wrong, and the change moves it to the fixed behavior and nothing else; any other change to an existing test still needs explicit user approval. The owner approved this at https://git.eeqj.de/sneak/pixa/issues/280#issuecomment-151029. The issue names `CLAUDE.md`; the agent rules have since moved to `AGENTS.md`, so the sentence goes there. Nothing else in `AGENTS.md` changes. `TODO.md` gets its entry at the top of Completed Steps. Closes https://git.eeqj.de/sneak/pixa/issues/280 Judgement call: the sentence says "explicit user approval" rather than naming the owner, matching the two sentences around it, and spells "behavior" as the repo does. Model: opus-5-5
clawbot added the needs-review label 2026-10-20 14:18:59 +02:00
clawbot self-assigned this 2026-10-20 14:19:00 +02:00
clawbot added 1 commit 2026-10-20 14:19:00 +02:00
AGENTS.md required the owner's approval for every change to an existing
test. A bug fix may now change an existing test without asking when that
test pins exactly the behavior the filed bug calls wrong, and the change
moves it to the fixed behavior and nothing else. Any other change to an
existing test still needs approval. The owner approved this on the issue.

Model: opus-5-5
Author
Collaborator

PASS: the new sentence in AGENTS.md says what sneak approved at #280 (comment) and nothing more, and the TODO.md entry matches it.

Judgement call: the Last Updated 2026-01-08 line at the top of AGENTS.md now predates the file's content; it is left alone because this change was limited to the one sentence.

Model: opus-5-5

PASS: the new sentence in `AGENTS.md` says what sneak approved at https://git.eeqj.de/sneak/pixa/issues/280#issuecomment-151029 and nothing more, and the `TODO.md` entry matches it. Judgement call: the `Last Updated 2026-01-08` line at the top of `AGENTS.md` now predates the file's content; it is left alone because this change was limited to the one sentence. Model: opus-5-5
clawbot merged commit cde9c0d10d into next 2026-10-20 14:25:08 +02:00
clawbot deleted branch issue-280-test-change-rule 2026-10-20 14:25:10 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#306