Escape state_dir in the db_url derived from it (closes #290) #292

Merged

clawbot merged 6 commits from issue-290-escape-state-dir-in-db-url into next 2026-10-16 04:37:55 +02:00

Conversation 6 Commits 6 Files Changed 4

+139 -7

6 Commits

Author	SHA1	Message	Date
sneak	78fe6957de	Keep the empty host when the db_url path starts with // ... defaultDBURL kept the empty host only when state_dir started with //, but SQLite reads the path written into the URL, state_dir followed by /state.sqlite3. For a state_dir of / that path is //state.sqlite3, the URL started file:// and SQLite read state.sqlite3 as a host, so pixa failed to start. The decision now looks at that path: a state_dir of / gives file:////state.sqlite3. Every other state_dir gives the same URL as before. Model: opus-5-5	2026-10-16 02:28:59 +00:00
sneak	339c149a4e	Test the db_url derived from a state_dir of / ... The path written into the URL is then //state.sqlite3, so the URL starts file:// and SQLite reads state.sqlite3 as a host. The test checks that the derived db_url starts file://// instead; it only checks the URL, since a test cannot write to /. Model: opus-5-5	2026-10-16 02:27:58 +00:00
sneak	afe000fb0f	Keep the empty host for a state_dir starting with // ... With OmitHost set, a state_dir starting with // gave a db_url starting file://, and SQLite read the first directory name as a host, so pixa failed to start. OmitHost is now left off for such a directory: the URL starts file://// and SQLite reads an empty host followed by the path. Every other state_dir gives the same URL as before. Model: opus-5-5	2026-10-16 02:27:58 +00:00
sneak	c593eae603	Test the db_url derived from a state_dir starting with // ... The test sets state_dir to a temporary directory with a / put in front, opens the derived db_url with the SQLite driver, and checks that the database is state.sqlite3 in that directory, in WAL mode. It fails while the URL starts file://, where SQLite reads the first directory name as a host. The open-and-check part of the test before it moves into a helper both tests call. Model: opus-5-5	2026-10-16 02:27:58 +00:00
sneak	d104d5d936	Escape state_dir in the db_url derived from it (closes #290) ... The derived db_url put state_dir into a file: URL as it was, so SQLite decoded a %HH in the name and ended the path at a ? or #, and the journal mode parameter was lost. It is now built with net/url, which percent-encodes the directory name; SQLite decodes it back and opens state.sqlite3 in that directory. OmitHost keeps the usual form file:/var/lib/pixa/state.sqlite3 and a relative state_dir a path. Model: opus-5-5	2026-10-16 02:27:58 +00:00
sneak	a997ede32b	Test the db_url derived from a state_dir holding %, ? and # ... The test sets state_dir to a directory named a%41b?c#d, opens the derived db_url with the SQLite driver, and checks that the database is state.sqlite3 in that directory, in WAL mode. It fails until the directory is escaped in the URL. Model: opus-5-5	2026-10-16 02:27:58 +00:00