Answer 415 for a source whose first bytes do not match its Content-Type (closes #253) #273

Merged

clawbot merged 2 commits from issue-253-first-bytes-mismatch-415 into next 2026-10-20 14:40:52 +02:00

Conversation 2 Commits 2 Files Changed 7

+247 -20

2 Commits

Author	SHA1	Message	Date
clawbot	985a6bb3fc	Answer 415 for a source whose first bytes do not match its Content-Type (closes #253) ... A body whose first bytes are not those of the format its Content-Type names answered 500 on both image routes, was logged as pixa's own error, and was fetched again on every request. Both routes now answer 415 for each error the first-bytes check returns, and the image service logs the refused source at warning level. The failure also gets a negative cache entry, as an upstream error status does, so the source URL is not fetched again for 5 minutes, and meanwhile an image that would need that fetch answers 502. README.md says so. The case of TestService_Get_ConcurrentMissesShareAFailure that expected such a source to be fetched again now expects the negative cache, as #280 (comment) allows. Model: opus-5-5	2026-10-20 12:28:34 +00:00
clawbot	4b6ffd1651	Test that a source not matching its Content-Type answers 415 ... Both image routes must answer 415 for an upstream body whose first bytes are not those of the format its Content-Type names, log it as a refused source and not at error level, and answer the next request for that source 502 without fetching it again. The test fails until the fix for #253. Model: opus-5-5	2026-10-20 12:28:16 +00:00