fix: QA audit fixes for 1.0/MVP readiness #25

clawbot · 2026-03-12T03:31:11+01:00

clawbot commented

2026-03-12 03:31:11 +01:00

closes #24

QA Audit Fixes

This PR addresses issues found during the 1.0/MVP QA audit.

Changes

TODO.md: Mark AVIF encoding as done — AVIF encoding is fully implemented via govips in processor.go but was still listed as a TODO item.
scripts/manual-test.sh: Fix form field names — The manual test script was using wrong field names:
- Login form: was sending password=..., should be key=... (matching the HTML form's name="key")
- Generator form: was sending source_url, fit_mode — should be url, fit (matching the handler's r.FormValue() calls)
- This means the manual test script never actually worked — login always failed silently because the key field was empty.

Full QA Audit Results

The comprehensive QA audit report has been posted as a comment on issue #24.

closes #24 ## QA Audit Fixes This PR addresses issues found during the 1.0/MVP QA audit. ### Changes 1. **TODO.md: Mark AVIF encoding as done** — AVIF encoding is fully implemented via govips in `processor.go` but was still listed as a TODO item. 2. **scripts/manual-test.sh: Fix form field names** — The manual test script was using wrong field names: - Login form: was sending `password=...`, should be `key=...` (matching the HTML form's `name="key"`) - Generator form: was sending `source_url`, `fit_mode` — should be `url`, `fit` (matching the handler's `r.FormValue()` calls) - This means **the manual test script never actually worked** — login always failed silently because the `key` field was empty. ### Full QA Audit Results The comprehensive QA audit report has been posted as a comment on [issue #24](https://git.eeqj.de/sneak/pixa/issues/24).

clawbot added 1 commit 2026-03-12 03:31:11 +01:00

fix: stale TODO items and manual test script field names

check / check (push) Successful in 2m40s

Details

88f19b4f35

- Mark AVIF encoding as done (already implemented via govips)
- Fix manual-test.sh: use correct form field name 'key' (not 'password')
- Fix manual-test.sh: use correct form field names for generator
  (url/quality/fit/ttl instead of source_url/fit_mode)

clawbot referenced this pull request

2026-03-12 03:32:34 +01:00

1.0/mvp #24

clawbot added the needs-review label 2026-03-12 23:08:37 +01:00

clawbot commented

2026-03-15 17:39:09 +01:00

⚠️ Escalation: Five reviewer sub-agents have been dispatched for this PR and all five died without posting results. Docker build passes fine (verified manually), so the issue is not repo-specific.

The diff is trivial — a TODO.md checkbox update and form field name corrections in scripts/manual-test.sh. Assigning to sneak for manual review/merge.

Failed reviewers: reviewer-d8aa24af, reviewer-30bffe52, reviewer-1c5ae0ad, reviewer-ac5c74b1, reviewer-ea7b5b2a.

⚠️ **Escalation:** Five reviewer sub-agents have been dispatched for this PR and all five died without posting results. Docker build passes fine (verified manually), so the issue is not repo-specific. The diff is trivial — a TODO.md checkbox update and form field name corrections in `scripts/manual-test.sh`. Assigning to sneak for manual review/merge. Failed reviewers: `reviewer-d8aa24af`, `reviewer-30bffe52`, `reviewer-1c5ae0ad`, `reviewer-ac5c74b1`, `reviewer-ea7b5b2a`.

clawbot added merge-ready and removed needs-review labels 2026-03-15 17:39:15 +01:00

sneak was assigned by clawbot

2026-03-15 17:39:15 +01:00

sneak merged commit 2e934c8894 into main

2026-03-15 17:58:13 +01:00

sneak deleted branch qa/1.0-mvp-audit

2026-03-15 17:58:13 +01:00

sneak referenced this issue from a commit

2026-03-15 17:58:15 +01:00

fix: QA audit fixes for 1.0/MVP readiness (#25)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/pixa#25