This PR addresses issues found during the 1.0/MVP QA audit.
Changes
TODO.md: Mark AVIF encoding as done — AVIF encoding is fully implemented via govips in processor.go but was still listed as a TODO item.
scripts/manual-test.sh: Fix form field names — The manual test script was using wrong field names:
Login form: was sending password=..., should be key=... (matching the HTML form's name="key")
Generator form: was sending source_url, fit_mode — should be url, fit (matching the handler's r.FormValue() calls)
This means the manual test script never actually worked — login always failed silently because the key field was empty.
Full QA Audit Results
The comprehensive QA audit report has been posted as a comment on issue #24.
closes #24
## QA Audit Fixes
This PR addresses issues found during the 1.0/MVP QA audit.
### Changes
1. **TODO.md: Mark AVIF encoding as done** — AVIF encoding is fully implemented via govips in `processor.go` but was still listed as a TODO item.
2. **scripts/manual-test.sh: Fix form field names** — The manual test script was using wrong field names:
- Login form: was sending `password=...`, should be `key=...` (matching the HTML form's `name="key"`)
- Generator form: was sending `source_url`, `fit_mode` — should be `url`, `fit` (matching the handler's `r.FormValue()` calls)
- This means **the manual test script never actually worked** — login always failed silently because the `key` field was empty.
### Full QA Audit Results
The comprehensive QA audit report has been posted as a comment on [issue #24](https://git.eeqj.de/sneak/pixa/issues/24).
- Mark AVIF encoding as done (already implemented via govips)
- Fix manual-test.sh: use correct form field name 'key' (not 'password')
- Fix manual-test.sh: use correct form field names for generator
(url/quality/fit/ttl instead of source_url/fit_mode)
⚠️Escalation: Five reviewer sub-agents have been dispatched for this PR and all five died without posting results. Docker build passes fine (verified manually), so the issue is not repo-specific.
The diff is trivial — a TODO.md checkbox update and form field name corrections in scripts/manual-test.sh. Assigning to sneak for manual review/merge.
⚠️ **Escalation:** Five reviewer sub-agents have been dispatched for this PR and all five died without posting results. Docker build passes fine (verified manually), so the issue is not repo-specific.
The diff is trivial — a TODO.md checkbox update and form field name corrections in `scripts/manual-test.sh`. Assigning to sneak for manual review/merge.
Failed reviewers: `reviewer-d8aa24af`, `reviewer-30bffe52`, `reviewer-1c5ae0ad`, `reviewer-ac5c74b1`, `reviewer-ea7b5b2a`.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
closes #24
QA Audit Fixes
This PR addresses issues found during the 1.0/MVP QA audit.
Changes
TODO.md: Mark AVIF encoding as done — AVIF encoding is fully implemented via govips in
processor.gobut was still listed as a TODO item.scripts/manual-test.sh: Fix form field names — The manual test script was using wrong field names:
password=..., should bekey=...(matching the HTML form'sname="key")source_url,fit_mode— should beurl,fit(matching the handler'sr.FormValue()calls)keyfield was empty.Full QA Audit Results
The comprehensive QA audit report has been posted as a comment on issue #24.
⚠️ Escalation: Five reviewer sub-agents have been dispatched for this PR and all five died without posting results. Docker build passes fine (verified manually), so the issue is not repo-specific.
The diff is trivial — a TODO.md checkbox update and form field name corrections in
scripts/manual-test.sh. Assigning to sneak for manual review/merge.Failed reviewers:
reviewer-d8aa24af,reviewer-30bffe52,reviewer-1c5ae0ad,reviewer-ac5c74b1,reviewer-ea7b5b2a.