sneak/pixa
1
0
Fork 0
Code Issues 31 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat: split Dockerfile into dedicated lint and build stages #22

Closed
clawbot wants to merge 1 commits from fix/20-split-dockerfile into main
pull from: fix/20-split-dockerfile
merge into: :main
Conversation 1 Commits 1 Files Changed 1
+27 -22
clawbot commented 2026-03-02 09:06:14 +01:00
Collaborator
Copy Link
Copy Source

Summary

Split the Dockerfile into a dedicated lint stage using the pre-built golangci/golangci-lint image, so lint and formatting failures surface much faster without downloading golangci-lint on every build.

Changes

  • New lint stage: Uses golangci/golangci-lint:v2.10.1 (sha256-pinned) with CGO deps for vips/libheif static analysis
  • Lint stage runs: make fmt-check + make lint — fast feedback on formatting/lint issues
  • Build stage runs: make test + binary compilation only
  • Removed: Manual golangci-lint binary download (17-line curl/checksum/extract block) — now handled by the pre-built image
  • Removed: curl from build stage deps (no longer needed)
  • Added: COPY --from=lint /src/go.sum /dev/null to force BuildKit to run the lint stage
  • Runtime stage: Unchanged

Verification

docker build . passes — lint, fmt-check, all tests, and binary compilation complete successfully.

closes #20

session: agent:sdlc-manager:subagent:fe0f0b24-ba66-4dc5-826c-a93700f6a93e

## Summary Split the Dockerfile into a dedicated lint stage using the pre-built `golangci/golangci-lint` image, so lint and formatting failures surface much faster without downloading golangci-lint on every build. ## Changes - **New lint stage**: Uses `golangci/golangci-lint:v2.10.1` (sha256-pinned) with CGO deps for vips/libheif static analysis - **Lint stage runs**: `make fmt-check` + `make lint` — fast feedback on formatting/lint issues - **Build stage runs**: `make test` + binary compilation only - **Removed**: Manual golangci-lint binary download (17-line curl/checksum/extract block) — now handled by the pre-built image - **Removed**: `curl` from build stage deps (no longer needed) - **Added**: `COPY --from=lint /src/go.sum /dev/null` to force BuildKit to run the lint stage - **Runtime stage**: Unchanged ## Verification `docker build .` passes — lint, fmt-check, all tests, and binary compilation complete successfully. closes https://git.eeqj.de/sneak/pixa/issues/20 `session: agent:sdlc-manager:subagent:fe0f0b24-ba66-4dc5-826c-a93700f6a93e`
clawbot added 1 commit 2026-03-02 09:06:15 +01:00
feat: split Dockerfile into dedicated lint and build stages
check / check (push) Successful in 5s
Details
de38b03508 
- Add dedicated lint stage using pre-built golangci-lint v2.10.1 image
- Move fmt-check and lint from build stage to lint stage for faster feedback
- Remove manual golangci-lint binary download (now handled by lint image)
- Remove curl from build stage dependencies (no longer needed)
- Add COPY --from=lint dependency to force BuildKit to run lint stage
- Build stage now runs only tests and compilation

closes #20
clawbot added the needs-review label 2026-03-02 09:06:25 +01:00
clawbot commented 2026-03-02 09:06:39 +01:00
Author
Collaborator
Copy Link
Copy Source

Closing — the referenced issue #21 was already closed.

Closing — the referenced issue #21 was already closed.
clawbot closed this pull request 2026-03-02 09:06:40 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#22