Add an integration test of the image proxy flow (closes #80)

Conversation 6 Commits 3 Files Changed 7

+473 -9

3 Commits

Author	SHA1	Message	Date
clawbot	c5eb8271e0	Test the image proxy flow end to end (closes #80 ) check / check (push) Failing after 2s Details TestImageProxyFlow in internal/server starts the database, handlers and middleware from the constructors pixad uses, in an fx app with a fresh state directory, and replaces only the upstream origin with a local test server, reached through the real fetcher by its new DialContext. For a resize with a change to JPEG and for orig, the first request answers 200 with the right content type, decoded size and X-Pixa-Cache MISS; the second answers HIT with the same image while the upstream has had one request; the source and the converted image are then on disk with their rows in SQLite. TODO.md records it and drops the item from Future Steps. Model: opus-5-5	2026-10-04 20:43:23 +00:00
clawbot	504f5d423d	Let a test give the handlers the upstream fetcher handlers.Params gets an optional Fetcher, marked optional for fx. When the app provides one, the handlers pass it to the image service, whose Fetcher option already existed for tests, instead of letting it build its own from the config. pixad provides none, so production builds its fetcher from the config exactly as before. A new test builds the handlers in an fx app that provides no fetcher, as pixad does, and checks that an allowlisted address in blocked_networks is refused with 403, which only the dialer that refuses internal addresses does. The comment on imgcache.ServiceConfig.FetcherConfig now says that its AllowHTTP and MaxResponseSize apply even when a fetcher is given. Model: opus-5-5	2026-10-04 20:42:56 +00:00
clawbot	a13df82530	Let a test give the upstream fetcher its own dial function httpfetcher.Config gets an optional DialContext. When it is set, New connects with it in place of the dialer that refuses internal addresses; the URL check and the redirect check still run. Nothing in the config file or the environment sets it, and pixa builds its fetcher without it, so production connects exactly as before. It lets a test outside this package send a public-looking address to a local test server. New tests check that a fetcher built without it refuses to connect to a local server, and that one built with it connects through it while a loopback URL and a redirect to a link-local address are still refused. Model: opus-5-5	2026-10-04 20:42:42 +00:00

Author

SHA1

Message

Date

clawbot

c5eb8271e0

Test the image proxy flow end to end (closes #80 )

check / check (push) Failing after 2s

Details

TestImageProxyFlow in internal/server starts the database, handlers and
middleware from the constructors pixad uses, in an fx app with a fresh
state directory, and replaces only the upstream origin with a local test
server, reached through the real fetcher by its new DialContext. For a
resize with a change to JPEG and for orig, the first request answers 200
with the right content type, decoded size and X-Pixa-Cache MISS; the
second answers HIT with the same image while the upstream has had one
request; the source and the converted image are then on disk with their
rows in SQLite. TODO.md records it and drops the item from Future Steps.

Model: opus-5-5

2026-10-04 20:43:23 +00:00

clawbot

504f5d423d

Let a test give the handlers the upstream fetcher

handlers.Params gets an optional Fetcher, marked optional for fx. When
the app provides one, the handlers pass it to the image service, whose
Fetcher option already existed for tests, instead of letting it build
its own from the config. pixad provides none, so production builds its
fetcher from the config exactly as before. A new test builds the
handlers in an fx app that provides no fetcher, as pixad does, and
checks that an allowlisted address in blocked_networks is refused with
403, which only the dialer that refuses internal addresses does. The
comment on imgcache.ServiceConfig.FetcherConfig now says that its
AllowHTTP and MaxResponseSize apply even when a fetcher is given.

Model: opus-5-5

2026-10-04 20:42:56 +00:00

clawbot

a13df82530

Let a test give the upstream fetcher its own dial function

httpfetcher.Config gets an optional DialContext. When it is set, New
connects with it in place of the dialer that refuses internal addresses;
the URL check and the redirect check still run. Nothing in the config
file or the environment sets it, and pixa builds its fetcher without it,
so production connects exactly as before. It lets a test outside this
package send a public-looking address to a local test server. New tests
check that a fetcher built without it refuses to connect to a local
server, and that one built with it connects through it while a loopback
URL and a redirect to a link-local address are still refused.

Model: opus-5-5

2026-10-04 20:42:42 +00:00

Add an integration test of the image proxy flow (closes #80) #195