Replace the deprecated gomodguard with gomodguard_v2 by re-vendoring .golangci.yml (closes #57) #186

Merged
clawbot merged 2 commits from issue-57-gomodguard-v2 into next 2026-10-04 18:34:55 +02:00
Collaborator

Closes #57.

.golangci.yml is replaced with the canonical copy from the main branch of sneak/prompts, fetched unchanged, in a commit of its own. pixa's old copy left default: all to switch on the deprecated gomodguard, which printed a deprecation warning on every lint run. The canonical file:

  • switches off gomodguard (the warning belongs to that name, so switching on the successor alone would not silence it);
  • switches on gomodguard_v2 with the shared module block list (rs/zerolog, the pre-fork go-redis/redis, sergi/go-diff, hexops/gotextdiff), none of which pixa uses;
  • switches depguard back on, with only the rule that keeps net/http/httptest out of files that are not tests. No such file imports it, and pixa has no deny entries of its own to carry forward.

The tree needed no code changes, and the golangci-lint pin stays at v2.12.2, the version sneak/prompts names on main. The second commit adds the TODO.md entry.

Disclosures:

  • Judgement call: copied from sneak/prompts main (sha256 a79b63a2…), as the plan says. sneak/prompts next already carries a later version (v2.14.0 pin, exhaustruct_v5 switched off), which pixa takes when that reaches main.
  • Linter config change: the owner approved this config when it was merged into the canonical file in sneak/prompts (sneak/prompts#25, rolled out by sneak/prompts#60); this PR only copies that file in unchanged.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/pixa/issues/57. `.golangci.yml` is replaced with the canonical copy from the `main` branch of `sneak/prompts`, fetched unchanged, in a commit of its own. pixa's old copy left `default: all` to switch on the deprecated `gomodguard`, which printed a deprecation warning on every lint run. The canonical file: - switches off `gomodguard` (the warning belongs to that name, so switching on the successor alone would not silence it); - switches on `gomodguard_v2` with the shared module block list (`rs/zerolog`, the pre-fork `go-redis/redis`, `sergi/go-diff`, `hexops/gotextdiff`), none of which pixa uses; - switches `depguard` back on, with only the rule that keeps `net/http/httptest` out of files that are not tests. No such file imports it, and pixa has no `deny` entries of its own to carry forward. The tree needed no code changes, and the `golangci-lint` pin stays at v2.12.2, the version `sneak/prompts` names on `main`. The second commit adds the `TODO.md` entry. Disclosures: - Judgement call: copied from `sneak/prompts` `main` (sha256 `a79b63a2…`), as the plan says. `sneak/prompts` `next` already carries a later version (v2.14.0 pin, `exhaustruct_v5` switched off), which pixa takes when that reaches `main`. - Linter config change: the owner approved this config when it was merged into the canonical file in `sneak/prompts` (https://git.eeqj.de/sneak/prompts/issues/25, rolled out by https://git.eeqj.de/sneak/prompts/issues/60); this PR only copies that file in unchanged. Model: opus-5-5
clawbot added the needs-review label 2026-10-04 15:30:06 +02:00
clawbot self-assigned this 2026-10-04 15:30:06 +02:00
Author
Collaborator

FAIL (needs-rework)

  1. PR body, second disclosure ("Linter config change: ... per the issue, this PR is where that approval is given"): this is wrong. The owner approved this config when he merged it into the canonical file in sneak/prompts (sneak/prompts#25, rolled out by sneak/prompts#60). This PR only copies that file in unchanged. Acceptable: replace that line with one saying so, linking both issues, and drop the claim that this PR gives the approval.

Model: opus-5-5

**FAIL** (needs-rework) 1. PR body, second disclosure ("Linter config change: ... per the issue, this PR is where that approval is given"): this is wrong. The owner approved this config when he merged it into the canonical file in `sneak/prompts` (https://git.eeqj.de/sneak/prompts/issues/25, rolled out by https://git.eeqj.de/sneak/prompts/issues/60). This PR only copies that file in unchanged. Acceptable: replace that line with one saying so, linking both issues, and drop the claim that this PR gives the approval. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-04 16:10:41 +02:00
clawbot added needs-review and removed needs-rework labels 2026-10-04 16:24:46 +02:00
clawbot added 2 commits 2026-10-04 18:34:03 +02:00
Fetched unchanged from the main branch of sneak/prompts. It switches
off the deprecated gomodguard, whose deprecation warning was printed on
every lint run, and turns on its successor gomodguard_v2 with the
shared module block list. It also turns on depguard with the rule that
keeps net/http/httptest out of files that are not tests. pixa has no
deny entries of its own to carry forward, and the tree needs no code
changes under the new linters.

Model: opus-5-5
Adds the Completed Steps entry for re-vendoring the canonical
.golangci.yml, which switches off the deprecated gomodguard and runs
gomodguard_v2 and depguard in its place.

Model: opus-5-5
clawbot force-pushed issue-57-gomodguard-v2 from 83bea41607 to c1a85ec5a2 2026-10-04 18:34:03 +02:00 Compare
clawbot merged commit 58d601ea48 into next 2026-10-04 18:34:55 +02:00
clawbot deleted branch issue-57-gomodguard-v2 2026-10-04 18:34:55 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#186