Removes dead code from internal/imgcache, per the plan on #73.
Purge is gone from the ImageCache interface and from Service, together with errPurgeNotImplemented. It only returned an error, nothing called it and no route exposed it. Eviction reclaims disk space meanwhile; purging can be reintroduced deliberately when a use case for it exists.
The SignatureValidator, Allowlist and Storage interfaces are deleted from imgcache.go. Nothing implemented or used them, and their methods do not match the real types (allowlist.HostAllowList, ContentStorage, VariantStorage).
TODO.md gets its Completed Steps entry.
No behaviour changes; the change is deletions only.
Disclosures:
No tests added or removed: no test exercised Purge or the deleted interfaces, and a deletion has no behaviour to test.
Judgement call: the ImageCache interface itself stays, as the plan says, although nothing besides Service refers to it.
Model: opus-5-5
Removes dead code from `internal/imgcache`, per the plan on https://git.eeqj.de/sneak/pixa/issues/73.
- `Purge` is gone from the `ImageCache` interface and from `Service`, together with `errPurgeNotImplemented`. It only returned an error, nothing called it and no route exposed it. Eviction reclaims disk space meanwhile; purging can be reintroduced deliberately when a use case for it exists.
- The `SignatureValidator`, `Allowlist` and `Storage` interfaces are deleted from `imgcache.go`. Nothing implemented or used them, and their methods do not match the real types (`allowlist.HostAllowList`, `ContentStorage`, `VariantStorage`).
- `TODO.md` gets its Completed Steps entry.
No behaviour changes; the change is deletions only.
Disclosures:
- No tests added or removed: no test exercised `Purge` or the deleted interfaces, and a deletion has no behaviour to test.
- Judgement call: the `ImageCache` interface itself stays, as the plan says, although nothing besides `Service` refers to it.
Model: opus-5-5
Purge only returned an error and nothing called it, so it is gone from
the ImageCache interface and from Service, along with its error value.
It can be added back when something needs it; eviction reclaims disk
space meanwhile. The SignatureValidator, Allowlist and Storage
interfaces in imgcache.go had no implementers and no users, and
described types that look different from the real ones, so they are
deleted. No behaviour changes.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Removes dead code from
internal/imgcache, per the plan on #73.Purgeis gone from theImageCacheinterface and fromService, together witherrPurgeNotImplemented. It only returned an error, nothing called it and no route exposed it. Eviction reclaims disk space meanwhile; purging can be reintroduced deliberately when a use case for it exists.SignatureValidator,AllowlistandStorageinterfaces are deleted fromimgcache.go. Nothing implemented or used them, and their methods do not match the real types (allowlist.HostAllowList,ContentStorage,VariantStorage).TODO.mdgets its Completed Steps entry.No behaviour changes; the change is deletions only.
Disclosures:
Purgeor the deleted interfaces, and a deletion has no behaviour to test.ImageCacheinterface itself stays, as the plan says, although nothing besidesServicerefers to it.Model: opus-5-5
PASS at
b08869501255ec5e74cd9237202c41ee2a1137c5, rebased ontonextat5b17d1f555fcc96afb79af19537a9d8e8d7cf1b0.Model: opus-5-5