Make the README's storage paths, formats, TLS and metrics match the code (closes #74) #172

Merged
clawbot merged 1 commits from issue-74-readme-accuracy into next 2026-10-04 06:24:38 +02:00
Collaborator

README.md described storage paths, formats and features that do not match the code (#74). Per the plan on that issue:

  • Storage names the directories pixa uses (cache/sources, cache/metadata, cache/variants) and how files are named in each, as internal/imgcache/storage.go does. The comments in internal/db/migrations/001_schema.sql name the same paths. No schema change.
  • Formats: one list under Routes, matching what internal/imgcache/urlparser.go accepts. The signature section points to that list and says jpg is signed as jpeg and original as orig, because the parsed name is what gets signed.
  • TLS: the sentence now names allow_http as its one exception.
  • Metrics says what exists: generic HTTP and Go runtime metrics at /metrics, recorded and served only when both metrics credentials are set.
  • The "1-5k r/s" sentence is unchanged. Since #70 it claims only what the code does.

Disclosures:

  • Judgement call: the output_content comment no longer names a path. It now says nothing writes the table, because transformed images are stored as variants. Removing the unused tables is outside this issue.
  • Judgement call: <statedir> is now <state_dir>, the config key's name, as the Configuration section already writes it.
  • Deviation: make fmt formats only Go (#100). The markdown is wrapped by hand at 80 columns, in the README's existing list style.

Model: opus-5-5

`README.md` described storage paths, formats and features that do not match the code (https://git.eeqj.de/sneak/pixa/issues/74). Per the plan on that issue: - **Storage** names the directories pixa uses (`cache/sources`, `cache/metadata`, `cache/variants`) and how files are named in each, as `internal/imgcache/storage.go` does. The comments in `internal/db/migrations/001_schema.sql` name the same paths. No schema change. - **Formats**: one list under Routes, matching what `internal/imgcache/urlparser.go` accepts. The signature section points to that list and says `jpg` is signed as `jpeg` and `original` as `orig`, because the parsed name is what gets signed. - **TLS**: the sentence now names `allow_http` as its one exception. - **Metrics** says what exists: generic HTTP and Go runtime metrics at `/metrics`, recorded and served only when both metrics credentials are set. - The "1-5k r/s" sentence is unchanged. Since https://git.eeqj.de/sneak/pixa/issues/70 it claims only what the code does. Disclosures: - Judgement call: the `output_content` comment no longer names a path. It now says nothing writes the table, because transformed images are stored as variants. Removing the unused tables is outside this issue. - Judgement call: `<statedir>` is now `<state_dir>`, the config key's name, as the Configuration section already writes it. - Deviation: `make fmt` formats only Go (https://git.eeqj.de/sneak/pixa/issues/100). The markdown is wrapped by hand at 80 columns, in the README's existing list style. Model: opus-5-5
clawbot added the needs-review label 2026-10-04 05:36:31 +02:00
clawbot self-assigned this 2026-10-04 05:36:31 +02:00
clawbot added 1 commit 2026-10-04 05:36:32 +02:00
"Storage" names the cache directories pixa uses (cache/sources,
cache/metadata, cache/variants) and how files are named in each; the
schema comments name the same paths, and the output_content comment says
the table is not written. Routes and the signature section give one list
of output formats, jpg and original included, and say how those two are
signed. The TLS sentence names allow_http as its exception. "Metrics"
says what exists: generic HTTP and Go runtime metrics at /metrics,
measured and served only when the metrics username and password are set.

Model: opus-5-5
Author
Collaborator

PASS at f2cf9d3e52cc7a1401db816e0eed5f9846dbeaf7, rebased onto next at 00da62db2cdd4b20512e0638e331ab14d31b8c49.

Model: opus-5-5

**PASS** at `f2cf9d3e52cc7a1401db816e0eed5f9846dbeaf7`, rebased onto `next` at `00da62db2cdd4b20512e0638e331ab14d31b8c49`. Model: opus-5-5
clawbot merged commit 3a274aaa44 into next 2026-10-04 06:24:38 +02:00
clawbot deleted branch issue-74-readme-accuracy 2026-10-04 06:24:38 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#172