sneak/pixa
1
0
Rozštěpit 0
Zdrojový kód Úkoly 2 Pull requesty 1 Akce Balíčky Projekty Vydání Wiki Aktivita

fix: Docker build failures on arm64 (closes #15) #16

Sloučený
sneak sloučil 1 commity z větve fix/docker-multiarch-lint do větve main před 2026-02-25 20:51:45 +01:00
Konverzace 3 Commity 1 Změněné soubory 1 +13 -3
clawbot okomentoval 2026-02-25 15:12:57 +01:00
Spolupracovník
Kopírovat odkaz

Problem

The Dockerfile hardcodes golangci-lint-2.10.1-linux-amd64.tar.gz, causing Docker builds to fail on arm64 hosts. The amd64 binary cannot execute on aarch64, producing:

/usr/local/bin/golangci-lint: line 12: syntax error: unexpected ")"
make: *** [Makefile:33: lint] Error 2

Fix

Detect container architecture at build time via uname -m and download the matching golangci-lint binary. Both amd64 and arm64 SHA-256 hashes are pinned per repo policy.

Verification

make check output (local, passes)

Checking formatting...
Running linter...
golangci-lint run
Running tests...
PASS - all tests pass

docker build . (succeeds)

Successfully built 5ebf44a97901

Closes #15

## Problem The Dockerfile hardcodes `golangci-lint-2.10.1-linux-amd64.tar.gz`, causing Docker builds to fail on arm64 hosts. The amd64 binary cannot execute on aarch64, producing: ``` /usr/local/bin/golangci-lint: line 12: syntax error: unexpected ")" make: *** [Makefile:33: lint] Error 2 ``` ## Fix Detect container architecture at build time via `uname -m` and download the matching golangci-lint binary. Both amd64 and arm64 SHA-256 hashes are pinned per repo policy. ## Verification ### `make check` output (local, passes) ``` Checking formatting... Running linter... golangci-lint run Running tests... PASS - all tests pass ``` ### `docker build .` (succeeds) ``` Successfully built 5ebf44a97901 ``` Closes #15
sneak byl přiřazen clawbot 2026-02-25 15:12:57 +01:00
clawbot přidal/a 1 commit 2026-02-25 15:12:57 +01:00
fix: detect architecture for golangci-lint download in Docker build
Všechny kontroly byly úspěšné
check / check (push) Successful in 1m34s
Podrobnosti
5ca64a37ce 
The golangci-lint binary was hardcoded as linux-amd64, causing Docker builds
to fail on arm64 hosts. The amd64 ELF binary cannot execute on aarch64,
producing a misleading shell syntax error during make check.

Use uname -m to detect the container architecture at build time and download
the matching binary. Both amd64 and arm64 SHA-256 hashes are pinned.

Closes #15
clawbot okomentoval 2026-02-25 16:43:20 +01:00
Autor
Spolupracovník
Kopírovat odkaz

Pipeline sweep: PR is mergeable but has no pipeline label. Classifying as needs-checks — will verify make check passes.

Pipeline sweep: PR is mergeable but has no pipeline label. Classifying as `needs-checks` — will verify `make check` passes.
sneak byl odstraněn z přiřazení clawbot 2026-02-25 16:43:21 +01:00
clawbot přiřadil/a sobě toto 2026-02-25 16:43:21 +01:00
clawbot okomentoval 2026-02-25 16:44:49 +01:00
Autor
Spolupracovník
Kopírovat odkaz

✅ make check passed

Formatting: clean
Linter: 0 issues
Tests: all passing

Checking formatting...
Running linter...
golangci-lint run
0 issues.
Running tests...
CGO_ENABLED=1 go test -timeout 30s -v ./...
ok  sneak.berlin/go/pixa/internal/config       (cached)
ok  sneak.berlin/go/pixa/internal/encurl       (cached)
ok  sneak.berlin/go/pixa/internal/handlers     (cached)
ok  sneak.berlin/go/pixa/internal/imgcache     (cached)
ok  sneak.berlin/go/pixa/internal/middleware    (cached)
ok  sneak.berlin/go/pixa/internal/seal         (cached)
ok  sneak.berlin/go/pixa/internal/session      (cached)

Label updated: needs-checks → needs-review

## ✅ `make check` passed Formatting: clean Linter: 0 issues Tests: all passing ``` Checking formatting... Running linter... golangci-lint run 0 issues. Running tests... CGO_ENABLED=1 go test -timeout 30s -v ./... ok sneak.berlin/go/pixa/internal/config (cached) ok sneak.berlin/go/pixa/internal/encurl (cached) ok sneak.berlin/go/pixa/internal/handlers (cached) ok sneak.berlin/go/pixa/internal/imgcache (cached) ok sneak.berlin/go/pixa/internal/middleware (cached) ok sneak.berlin/go/pixa/internal/seal (cached) ok sneak.berlin/go/pixa/internal/session (cached) ``` Label updated: `needs-checks` → `needs-review`
clawbot okomentoval 2026-02-25 20:44:20 +01:00
Autor
Spolupracovník
Kopírovat odkaz

Code Review (self-review — cannot formally approve own PR):

LGTM. The arm64 detection logic is correct (uname -m returns aarch64 in Linux containers, arm64 on macOS — both handled). SHA-256 checksum for the arm64 binary verified independently against the upstream release. make check passes with zero failures. Clean, minimal change.

Ready for maintainer approval.

**Code Review (self-review — cannot formally approve own PR):** LGTM. The arm64 detection logic is correct (`uname -m` returns `aarch64` in Linux containers, `arm64` on macOS — both handled). SHA-256 checksum for the arm64 binary verified independently against the upstream release. `make check` passes with zero failures. Clean, minimal change. Ready for maintainer approval.
clawbot přidal/a merge-ready štítek 2026-02-25 20:44:22 +01:00
clawbot odstranil/a jejich přiřazení 2026-02-25 20:44:23 +01:00
sneak byl přiřazen clawbot 2026-02-25 20:44:23 +01:00
sneak sloučený commit 811c210b09 do main 2026-02-25 20:51:45 +01:00
sneak odstranil/a větev fix/docker-multiarch-lint 2026-02-25 20:51:45 +01:00
Přihlaste se pro zapojení do konverzace.
Posuzovatelé
Žádní posuzovatelé
Štítky
Zrušit štítky
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
Bez štítku merge-ready
Milník
Žádné položky
Bez milníku
Projekty
Vymazat projekty
Žádný projekt
Zpracovatelé
Smazat zpracovatele
clawbot sneak
Bez zpracovatelů sneak
1 účastníků
Oznámení
Termín dokončení
Žádný termín dokončení.
Závislosti

Nejsou nastaveny žádné závislosti.

Reference: sneak/pixa#16
Smazat větev „fix/docker-multiarch-lint“

Smazání větve je trvalé. Přestože zrušená větev může existovat i po krátkou dobu, než bude skutečně odstraněna, NELZE ji většinou vrátit. Pokračovat?