fix: check negative cache in Service.Get() before fetching upstream (closes #3) #8

clawbot · 2026-02-09T01:00:15+01:00

clawbot skomentował(-a)

2026-02-09 01:00:15 +01:00

No description provided.

sneak zostaje przypisany(-a) przez clawbot

2026-02-09 01:00:15 +01:00

clawbot dodał(-a) 1 commit 2026-02-09 01:00:15 +01:00

fix: check negative cache in Service.Get() before fetching upstream 5690dc39f4

The checkNegativeCache() method existed but was never called, making
negative caching (for failed fetches) completely non-functional.
Failed URLs were being re-fetched on every request.

Add negative cache check at the start of Service.Get() to short-circuit
requests for recently-failed URLs.

Fixes #3

clawbot force-pushed fix/issue-3 from 5690dc39f4 to e651e672aa

2026-02-09 01:02:36 +01:00

Porównaj

clawbot skomentował(-a)

2026-02-09 01:11:19 +01:00

Test only (no fix): FAIL

# sneak.berlin/go/pixa/internal/imgcache [sneak.berlin/go/pixa/internal/imgcache.test]
internal/imgcache/negative_cache_test.go:96:9: undefined: ErrNegativeCached
internal/imgcache/negative_cache_test.go:97:21: undefined: ErrNegativeCached
FAIL	sneak.berlin/go/pixa/internal/imgcache [build failed]
FAIL

Test + fix: PASS

ok  	sneak.berlin/go/pixa/internal/config
ok  	sneak.berlin/go/pixa/internal/encurl
ok  	sneak.berlin/go/pixa/internal/handlers
ok  	sneak.berlin/go/pixa/internal/imgcache
ok  	sneak.berlin/go/pixa/internal/middleware
ok  	sneak.berlin/go/pixa/internal/seal
ok  	sneak.berlin/go/pixa/internal/session

### Test only (no fix): FAIL ``` # sneak.berlin/go/pixa/internal/imgcache [sneak.berlin/go/pixa/internal/imgcache.test] internal/imgcache/negative_cache_test.go:96:9: undefined: ErrNegativeCached internal/imgcache/negative_cache_test.go:97:21: undefined: ErrNegativeCached FAIL sneak.berlin/go/pixa/internal/imgcache [build failed] FAIL ``` ### Test + fix: PASS ``` ok sneak.berlin/go/pixa/internal/config ok sneak.berlin/go/pixa/internal/encurl ok sneak.berlin/go/pixa/internal/handlers ok sneak.berlin/go/pixa/internal/imgcache ok sneak.berlin/go/pixa/internal/middleware ok sneak.berlin/go/pixa/internal/seal ok sneak.berlin/go/pixa/internal/session ```

sneak dodał(-a) 1 commit 2026-02-09 01:32:19 +01:00

Merge branch 'main' into fix/issue-3 3d857da237

sneak merged commit b800ef86d8 into main

2026-02-09 01:32:27 +01:00

sneak wspomniał(-a) to zgłoszenie z commita

2026-02-09 01:32:28 +01:00

Merge pull request 'fix: check negative cache in Service.Get() before fetching upstream (closes #3)' (#8) from fix/issue-3 into main

Zaloguj się, aby dołączyć do tej rozmowy.

Uczestnicy 2

Powiadomienia

Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: sneak/pixa#8