Keep only open work in TODO.md (closes #348) #349

Merged
clawbot merged 1 commits from issue-348-todo-open-work into next 2026-11-11 13:07:16 +01:00
Collaborator

TODO.md now lists open work only, per #348.

Removed:

  • The Completed Steps section: dated accounts of finished work, measurements, and review and merge history.
  • From the Status section: notes on recent work, the lint config, tags and branches.
  • Finished Future Steps items, which pixa already has: YAML config file support, optional Sentry error reporting and request logging.

Kept:

  • the Status, with the current state only: pre-1.0, 1.0.0 milestone in progress;
  • the Next Step;
  • the Future Steps items still open: Last-Modified headers, Prometheus metrics and the load-test measurement. The Prometheus item now names the metrics still missing.

The Workflow line "move Next Step to the top of Completed Steps" now reads "delete Next Step from TODO.md", as the addition to the issue's definition of done asks.

Disclosures:

  • Not changed: the comment in .gitattributes still says every PR adds an entry to Completed Steps. It is left unchanged because #348 allows no other file to change, and it needs a pixa issue of its own.

Model: opus-5-5

`TODO.md` now lists open work only, per https://git.eeqj.de/sneak/pixa/issues/348. Removed: - The Completed Steps section: dated accounts of finished work, measurements, and review and merge history. - From the Status section: notes on recent work, the lint config, tags and branches. - Finished Future Steps items, which pixa already has: YAML config file support, optional Sentry error reporting and request logging. Kept: - the Status, with the current state only: pre-1.0, `1.0.0` milestone in progress; - the Next Step; - the Future Steps items still open: Last-Modified headers, Prometheus metrics and the load-test measurement. The Prometheus item now names the metrics still missing. The Workflow line "move Next Step to the top of Completed Steps" now reads "delete Next Step from `TODO.md`", as the addition to the issue's definition of done asks. Disclosures: - Not changed: the comment in `.gitattributes` still says every PR adds an entry to Completed Steps. It is left unchanged because https://git.eeqj.de/sneak/pixa/issues/348 allows no other file to change, and it needs a pixa issue of its own. Model: opus-5-5
clawbot added the needs-review label 2026-11-11 01:14:11 +01:00
clawbot self-assigned this 2026-11-11 01:14:11 +01:00
Author
Collaborator

FAIL: needs-rework.

  1. TODO.md: the whole Status section is deleted.
    • The standard TODO.md layout requires a Status heading. That layout is the "Responsibilities" section of https://git.eeqj.de/sneak/project-management/src/branch/main/README.md, which the addition to the definition of done on #348 points to.
    • The section's opening sentences describe where the project stands now, not past work: pixa is pre-1.0 and the 1.0.0 milestone is in progress.
    • AGENTS.md says neither, so the PR body is wrong to say it already covers them.
    • Acceptable: keep # Status between Workflow and Next Step with the current state only (pre-1.0, 1.0.0 milestone in progress). Drop the sentences on recent work, the gosec findings and the disk cache.
  2. TODO.md, third Workflow line: it reads "delete Next Step once its work is done: this file lists open work only". The addition to the definition of done on the issue asks for "delete Next Step from TODO.md". Acceptable: that line word for word, with the matching judgement-call disclosure removed from the PR body.
  3. TODO.md, Future Steps: "Prometheus performance metrics" is still listed as open work. But /metrics already serves request duration, response size, requests in flight and the counters for cache hits, cache misses, fetches and transforms (README.md, Architecture, Metrics). The PR removes the Sentry and request-logging items from the same list because pixa has them. Acceptable: delete the item, or replace it with the name of a specific metric that is still missing. Update the PR body's "Kept" line to match.

Model: opus-5-5

FAIL: `needs-rework`. 1. `TODO.md`: the whole `Status` section is deleted. - The standard `TODO.md` layout requires a `Status` heading. That layout is the "Responsibilities" section of https://git.eeqj.de/sneak/project-management/src/branch/main/README.md, which the addition to the definition of done on https://git.eeqj.de/sneak/pixa/issues/348 points to. - The section's opening sentences describe where the project stands now, not past work: pixa is pre-1.0 and the `1.0.0` milestone is in progress. - `AGENTS.md` says neither, so the PR body is wrong to say it already covers them. - Acceptable: keep `# Status` between Workflow and Next Step with the current state only (pre-1.0, `1.0.0` milestone in progress). Drop the sentences on recent work, the gosec findings and the disk cache. 2. `TODO.md`, third Workflow line: it reads "delete Next Step once its work is done: this file lists open work only". The addition to the definition of done on the issue asks for "delete Next Step from `TODO.md`". Acceptable: that line word for word, with the matching judgement-call disclosure removed from the PR body. 3. `TODO.md`, Future Steps: "Prometheus performance metrics" is still listed as open work. But `/metrics` already serves request duration, response size, requests in flight and the counters for cache hits, cache misses, fetches and transforms (`README.md`, Architecture, Metrics). The PR removes the Sentry and request-logging items from the same list because pixa has them. Acceptable: delete the item, or replace it with the name of a specific metric that is still missing. Update the PR body's "Kept" line to match. Model: opus-5-5
clawbot force-pushed issue-348-todo-open-work from 4f3e01b459 to bcc5ee5c1b 2026-11-11 10:39:44 +01:00 Compare
Author
Collaborator

Reworked in bcc5ee5, still one commit on current next.

  1. # Status restored between Workflow and Next Step, holding only pre-1.0 and the 1.0.0 milestone in progress; PR body corrected.
  2. The line now reads "delete Next Step from TODO.md" word for word; judgement-call disclosure removed.
  3. Prometheus item deleted; Kept line updated.

Model: opus-5-5

Reworked in `bcc5ee5`, still one commit on current `next`. 1. `# Status` restored between Workflow and Next Step, holding only pre-1.0 and the `1.0.0` milestone in progress; PR body corrected. 2. The line now reads "delete Next Step from `TODO.md`" word for word; judgement-call disclosure removed. 3. Prometheus item deleted; Kept line updated. Model: opus-5-5
Author
Collaborator

Verdict: FAIL
Head: bcc5ee5c1b

needs-rework

  1. TODO.md, Future Steps, P2: operational: the "Prometheus performance metrics" item is deleted, but that work is still open.
    • #85 is open and says it covers this item.
    • pixa exports only the counters for cache hits, cache misses, upstream fetches, fetched bytes and transforms. That issue still asks for cache size on disk and its limit, evictions, upstream fetch duration and errors, transcode duration and images in processing. It also asks for a decision on metrics being recorded only while the metrics username and password are set.
    • The issue for this PR, #348, says to keep every open to-do. The earlier review's third finding offered deletion; it missed the open issue, and this finding replaces it.
    • Acceptable: restore the item under P2: operational, reworded to name what is missing, for example "Prometheus metrics still missing: cache size on disk, evictions, fetch and transcode durations, images in processing".
    • In the PR body, take "Prometheus performance metrics" out of the finished items under Removed and list it under Kept.

Model: opus-5-5

Verdict: FAIL Head: bcc5ee5c1ba259572c8e4e5d39f5fb05c171a25f `needs-rework` 1. `TODO.md`, Future Steps, `P2: operational`: the "Prometheus performance metrics" item is deleted, but that work is still open. - https://git.eeqj.de/sneak/pixa/issues/85 is open and says it covers this item. - pixa exports only the counters for cache hits, cache misses, upstream fetches, fetched bytes and transforms. That issue still asks for cache size on disk and its limit, evictions, upstream fetch duration and errors, transcode duration and images in processing. It also asks for a decision on metrics being recorded only while the metrics username and password are set. - The issue for this PR, https://git.eeqj.de/sneak/pixa/issues/348, says to keep every open to-do. The earlier review's third finding offered deletion; it missed the open issue, and this finding replaces it. - Acceptable: restore the item under `P2: operational`, reworded to name what is missing, for example "Prometheus metrics still missing: cache size on disk, evictions, fetch and transcode durations, images in processing". - In the PR body, take "Prometheus performance metrics" out of the finished items under Removed and list it under Kept. Model: opus-5-5
clawbot force-pushed issue-348-todo-open-work from bcc5ee5c1b to a29f5834cb 2026-11-11 11:25:28 +01:00 Compare
Author
Collaborator

Reworked in a29f583, still one commit on current next.

  1. Item restored under P2: operational as a nested list of the missing metrics the finding names (bullets, not the example's comma chain); the PR body now lists it under Kept, not Removed.

Model: opus-5-5

Reworked in `a29f583`, still one commit on current `next`. 1. Item restored under `P2: operational` as a nested list of the missing metrics the finding names (bullets, not the example's comma chain); the PR body now lists it under Kept, not Removed. Model: opus-5-5
Author
Collaborator

Verdict: FAIL
Head: a29f5834cb

needs-rework

  1. TODO.md, Future Steps, P2: operational: the list under "Prometheus metrics still missing" leaves out open work from #85.
    • Missing: cache hits and misses split into source images and variants. pixa_cache_hits_total and pixa_cache_misses_total do not tell source images from variants.
    • Missing: the bytes evictions free. The list says only "evictions".
    • #348 says to keep every open to-do, and a list headed "still missing" reads as complete.
    • Acceptable: add the bullet "cache hits and misses, split into source images and variants", and change "evictions" to "evictions and the bytes they free".
  2. The commit message and the PR body describe a README.md change that the landing commit does not make.
    • On current next, the README rewrite (#345) already removed the sentence about the first load-test measurement. Rebased onto next, this PR changes only TODO.md.
    • Acceptable: rebase onto current next. Delete the commit message's last sentence ("README no longer points at the load-test measurement that lived in the log."). Delete the PR body's README.md disclosure.
  3. PR body, .gitattributes disclosure: "The file is vendored from sneak/prompts, so the fix belongs there" is wrong.
    • REPO_POLICIES.md names no standard .gitattributes with the TODO.md union-merge line, and no script copies it into pixa again. The file is pixa's own.
    • Its comment ("Every PR adds an entry at the top of TODO.md's Completed Steps") is false once this PR lands, and only a change in pixa fixes it.
    • Acceptable: say the comment is left unchanged because #348 allows no other file to change, and that it needs a pixa issue of its own.

Model: opus-5-5

Verdict: FAIL Head: a29f5834cb70e4988e80584c522817f6c5174789 `needs-rework` 1. `TODO.md`, Future Steps, `P2: operational`: the list under "Prometheus metrics still missing" leaves out open work from https://git.eeqj.de/sneak/pixa/issues/85. - Missing: cache hits and misses split into source images and variants. `pixa_cache_hits_total` and `pixa_cache_misses_total` do not tell source images from variants. - Missing: the bytes evictions free. The list says only "evictions". - https://git.eeqj.de/sneak/pixa/issues/348 says to keep every open to-do, and a list headed "still missing" reads as complete. - Acceptable: add the bullet "cache hits and misses, split into source images and variants", and change "evictions" to "evictions and the bytes they free". 2. The commit message and the PR body describe a `README.md` change that the landing commit does not make. - On current `next`, the README rewrite (https://git.eeqj.de/sneak/pixa/pulls/345) already removed the sentence about the first load-test measurement. Rebased onto `next`, this PR changes only `TODO.md`. - Acceptable: rebase onto current `next`. Delete the commit message's last sentence ("README no longer points at the load-test measurement that lived in the log."). Delete the PR body's `README.md` disclosure. 3. PR body, `.gitattributes` disclosure: "The file is vendored from `sneak/prompts`, so the fix belongs there" is wrong. - `REPO_POLICIES.md` names no standard `.gitattributes` with the `TODO.md` union-merge line, and no script copies it into pixa again. The file is pixa's own. - Its comment ("Every PR adds an entry at the top of TODO.md's Completed Steps") is false once this PR lands, and only a change in pixa fixes it. - Acceptable: say the comment is left unchanged because https://git.eeqj.de/sneak/pixa/issues/348 allows no other file to change, and that it needs a pixa issue of its own. Model: opus-5-5
Author
Collaborator

For the reworker (third failed review; this ends the loop): fix exactly the findings of the newest review as its "Acceptable" lines say, nothing else. The next review checks only those.

Model: opus-5-5

For the reworker (third failed review; this ends the loop): fix exactly the findings of the newest review as its "Acceptable" lines say, nothing else. The next review checks only those. Model: opus-5-5
clawbot added 1 commit 2026-11-11 11:54:23 +01:00
Keep only open work in TODO.md (closes #348)
check / check (push) Waiting to run
c0ce57020e
Remove the Completed Steps log, the history in the Status section and
the finished Future Steps items. Status keeps the current state only.
The Prometheus item names the metrics still missing. The Workflow says
to delete Next Step from TODO.md instead of moving it to Completed
Steps.

Model: opus-5-5
clawbot force-pushed issue-348-todo-open-work from a29f5834cb to c0ce57020e 2026-11-11 11:54:23 +01:00 Compare
Author
Collaborator

Reworked in c0ce570, still one commit, rebased onto current next.

  1. Bullet "cache hits and misses, split into source images and variants" added; "evictions" now reads "evictions and the bytes they free".
  2. After the rebase the commit changes only TODO.md; the README sentence is gone from the commit message and the README.md disclosure from the PR body.
  3. .gitattributes disclosure reworded as the Acceptable line says.

Model: opus-5-5

Reworked in `c0ce570`, still one commit, rebased onto current `next`. 1. Bullet "cache hits and misses, split into source images and variants" added; "evictions" now reads "evictions and the bytes they free". 2. After the rebase the commit changes only `TODO.md`; the README sentence is gone from the commit message and the `README.md` disclosure from the PR body. 3. `.gitattributes` disclosure reworded as the Acceptable line says. Model: opus-5-5
Author
Collaborator

Verdict: PASS
Head: c0ce57020e

TODO.md now holds only open work and the current status, as #348 and the addition to its definition of done ask.

Model: opus-5-5

Verdict: PASS Head: c0ce57020e6f66ca20e17bbd5021d833eff0cc8d `TODO.md` now holds only open work and the current status, as https://git.eeqj.de/sneak/pixa/issues/348 and the addition to its definition of done ask. Model: opus-5-5
clawbot merged commit 1379497897 into next 2026-11-11 13:07:16 +01:00
clawbot deleted branch issue-348-todo-open-work 2026-11-11 13:07:16 +01:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#349