fix: propagate AllowHTTP to SourceURL() scheme selection

SourceURL() previously hardcoded https:// regardless of the AllowHTTP
config setting. This made testing with HTTP-only test servers impossible.

Add AllowHTTP field to ImageRequest and use it to determine the URL
scheme. The Service propagates the config setting to each request.

Fixes #1

.gitignore

@@ -18,7 +18,3 @@ vendor/
 # Data
 /data/
 *.sqlite3
-
-# Local dev configs
-config.yaml
-config.dev.yml

config.dev.yml

@@ -0,0 +1,11 @@
+# Development config for local Docker testing
+signing_key: "dev-signing-key-minimum-32-chars!"
+debug: true
+allow_http: true
+whitelist_hosts:
+  - localhost
+  - s3.sneak.cloud
+  - static.sneak.cloud
+  - sneak.berlin
+  - github.com
+  - user-images.githubusercontent.com

config.yaml

@@ -0,0 +1,10 @@
+debug: true
+port: 8080
+state_dir: ./data
+signing_key: "test-signing-key-for-development-only"
+whitelist_hosts:
+  - "*.example.com"
+  - "images.unsplash.com"
+  - "picsum.photos"
+  - "s3.sneak.cloud"
+allow_http: false

internal/imgcache/sourceurl_test.go

@@ -18,9 +18,9 @@ func TestImageRequest_SourceURL_DefaultHTTPS(t *testing.T) {
 
 func TestImageRequest_SourceURL_AllowHTTP(t *testing.T) {
 	req := &ImageRequest{
-		SourceHost: "localhost:8080",
+		SourceHost:  "localhost:8080",
-		SourcePath: "/photos/cat.jpg",
+		SourcePath:  "/photos/cat.jpg",
-		AllowHTTP:  true,
+		AllowHTTP:   true,
 	}
 
 	got := req.SourceURL()