Bug: SourceURL() hardcodes https:// breaking AllowHTTP mode #1

Nowe zgłoszenie

clawbot · 2026-02-09T00:56:06+01:00

clawbot skomentował(-a)

2026-02-09 00:56:06 +01:00

Bug

ImageRequest.SourceURL() in internal/imgcache/imgcache.go always prepends https://:

func (r *ImageRequest) SourceURL() string {
    url := "https://" + r.SourceHost + r.SourcePath

When AllowHTTP is configured (for testing), the fetcher validates the URL scheme and the HTTP fetcher creates the request, but the source URL is always https://. This means in testing mode with HTTP-only test servers, fetches will either fail with TLS errors or connect to the wrong port.

The AllowHTTP config is set but SourceURL() has no awareness of it, making the entire AllowHTTP feature broken for any real HTTP upstream.

Impact

Blocks testing with local HTTP servers. The AllowHTTP config option is effectively non-functional for the image proxy pipeline.

Fix

Pass the scheme through ImageRequest or add a method parameter. The cleanest approach is to add a Scheme field to ImageRequest that defaults to https but can be set to http when AllowHTTP is true.

## Bug `ImageRequest.SourceURL()` in `internal/imgcache/imgcache.go` always prepends `https://`: ```go func (r *ImageRequest) SourceURL() string { url := "https://" + r.SourceHost + r.SourcePath ``` When `AllowHTTP` is configured (for testing), the fetcher validates the URL scheme and the HTTP fetcher creates the request, but the source URL is always `https://`. This means in testing mode with HTTP-only test servers, fetches will either fail with TLS errors or connect to the wrong port. The `AllowHTTP` config is set but `SourceURL()` has no awareness of it, making the entire `AllowHTTP` feature broken for any real HTTP upstream. ## Impact Blocks testing with local HTTP servers. The `AllowHTTP` config option is effectively non-functional for the image proxy pipeline. ## Fix Pass the scheme through `ImageRequest` or add a method parameter. The cleanest approach is to add a `Scheme` field to `ImageRequest` that defaults to `https` but can be set to `http` when `AllowHTTP` is true.

clawbot przypisuje to na siebie 2026-02-09 00:56:06 +01:00

clawbot wspomniał(-a) to zgłoszenie z commita

2026-02-09 00:59:58 +01:00

fix: propagate AllowHTTP to SourceURL() scheme selection

clawbot odwołał(-a) się do Pull Requesta , który zamknie to zgłoszenie

2026-02-09 01:00:12 +01:00

fix: propagate AllowHTTP to SourceURL() scheme selection (closes #1) #6

clawbot wspomniał(-a) to zgłoszenie z commita

2026-02-09 01:34:24 +01:00

fix: propagate AllowHTTP to SourceURL() scheme selection

clawbot wspomniał(-a) to zgłoszenie z commita

2026-02-09 01:34:45 +01:00