Delete a negative-cache test that tests nothing (closes #347)
check / check (push) Waiting to run
check / check (push) Waiting to run
TestProxy_Get_ReturnsErrorForNegativeCachedURL never called Get; it only checked ErrNegativeCached against itself. The test above it covers Get returning ErrNegativeCached. Deletion approved by sneak on the issue. Model: opus-5-5
This commit was merged in pull request #354.
This commit is contained in:
1 parent
7f87aa17ca
commit
092176d917
1 file changed
-12
@@ -82,15 +82,3 @@ func TestProxy_Get_ServesCachedVariantOfNegativeCachedURL(t *testing.T) {
|
||||
err, ErrNegativeCached)
|
||||
}
|
||||
}
|
||||
|
||||
func TestProxy_Get_ReturnsErrorForNegativeCachedURL(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
// This test verifies that Proxy.Get() checks the negative cache
|
||||
// We can't easily test the full pipeline without vips, but we can
|
||||
// verify the error type
|
||||
err := ErrNegativeCached
|
||||
if !errors.Is(err, ErrNegativeCached) {
|
||||
t.Error("ErrNegativeCached should be identifiable with errors.Is")
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user